Skip to content

expand-home should be consistent in what it returns#87

Merged
Raynes merged 2 commits into
Raynes:masterfrom
egli:expand_home_should_always_return_file
Jan 14, 2016
Merged

expand-home should be consistent in what it returns#87
Raynes merged 2 commits into
Raynes:masterfrom
egli:expand_home_should_always_return_file

Conversation

@egli

@egli egli commented Sep 10, 2014

Copy link
Copy Markdown
Contributor

Usually if you pass it a path string that starts with ~ it returns a
file. However if the path string does not start with ~ it simply
returns the string. This change makes the return value consistent:
always a file.

egli and others added 2 commits September 10, 2014 23:04
Usually if you pass it a path string that starts with `~` it returns a
file. However if the path string does not start with `~` it simply
returns the string. This change makes the return value consistent:
always a file.
@egli

egli commented Sep 11, 2014

Copy link
Copy Markdown
Contributor Author

Not sure though if expand-home should really return a file. Maybe it should always return a string? If you want I can change it either way.

Raynes added a commit that referenced this pull request Jan 14, 2016
expand-home should be consistent in what it returns
@Raynes
Raynes merged commit 77e220c into Raynes:master Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants