Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Disable Roomote Control on logout - #7976

Merged
cte merged 4 commits into
mainfrom
cte/disable-roomote-control-on-logout
Sep 14, 2025
Merged

Disable Roomote Control on logout#7976
cte merged 4 commits into
mainfrom
cte/disable-roomote-control-on-logout

Conversation

@cte

@cte cte commented Sep 14, 2025

Copy link
Copy Markdown
Contributor

After logging out we're not able to fetch the roomote control settings and we were short-circuiting the disconnect logic in the case that the setting fetch failed.


Important

Disable remote control on logout by updating BridgeOrchestrator and ClineProvider logic and adding tests.

  • Behavior:
    • BridgeOrchestrator.isEnabled() now returns false if user is null or remoteControlEnabled is false.
    • ClineProvider.remoteControlEnabled() disconnects BridgeOrchestrator if enabled is false or userInfo is null.
    • extension.ts calls provider.remoteControlEnabled(false) on logout.
  • Tests:
    • Added extension.spec.ts to test authStateChangedHandler calls BridgeOrchestrator.disconnect() on logout.
  • Misc:
    • Updated logging messages in extension.ts for clarity.

This description was created by Ellipsis for 9ef637c. You can customize this summary. It will automatically update as commits are pushed.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants