Feature/ctrl enter send by lmtr0 · Pull Request #8556 · RooCodeInc/Roo-Code

lmtr0 · 2025-10-07T23:30:36Z

Related GitHub Issue

Closes: #8555

Description

This PR introduces a new toggle in the settings under the "UI" section that allows users to switch between two input behaviors in the chat prompt editor:

Enter = newline, Shift+Enter / Ctrl+Enter = send
Enter = send, Shift+Enter = newline (current default)

The change is implemented by listening to the keydown event in the prompt input component and conditionally intercepting the Enter key based on the user’s preference, which is stored via VS Code’s configuration API.

This addresses user pain points around accidental submissions, ergonomic fatigue from holding Shift, and conflicts with input method workflows.

Test Procedure

Send a message normally in the chat input
Enable the feature
Be happy that when you press enter, you receive a new line, and when you press ctrl+enter, the message is sent.
Disable the feature
Be happy that everything is back to default behavior.

Pre-Submission Checklist

Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
Scope: My changes are focused on the linked issue (one major feature/fix per PR).
Self-Review: I have performed a thorough self-review of my code.
Testing: New and/or updated tests have been added to cover my changes (if applicable).
Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

The settings panel

Didn't send the message after pressing enter:

Did send it when pressing ctrl+enter

Documentation Updates

This implementation does not introduce any new hardcoded keybindings beyond using standard modifier combinations (Shift+Enter, Ctrl+Enter), which are already common in chat interfaces.
It would be ideal if there are documentation written to allow users to understand how to change the setting, but I think it is very intuitive
I do not have time to write docs for this feature

Additional Notes

Get in Touch

Discord: lmtr0

Important

Adds a new setting requireCtrlEnterToSend to toggle input behavior in the chat prompt editor, allowing users to require Ctrl+Enter to send messages.

Behavior:
- Adds requireCtrlEnterToSend setting to toggle input behavior in chat prompt editor.
- In ChatTextArea.tsx, modifies handleKeyDown to conditionally send messages based on requireCtrlEnterToSend.
Settings:
- Adds requireCtrlEnterToSend to globalSettingsSchema in global-settings.ts.
- Updates UISettings.tsx to include a checkbox for requireCtrlEnterToSend.
- Updates SettingsView.tsx to handle requireCtrlEnterToSend state.
State Management:
- Updates ExtensionStateContext.tsx to manage requireCtrlEnterToSend state.
- Modifies webviewMessageHandler.ts to handle requireCtrlEnterToSend messages.
Localization:
- Adds localization strings for requireCtrlEnterToSend in settings.json.

^{This description was created by}^{for 9d206cb. You can customize this summary. It will automatically update as commits are pushed.}

ghost

I found some issues that need attention before merge.

ghost

I found a couple of small issues to address before merging.

…ocode into feature/ctrl-enter-send

ghost

I found some issues that need attention before merge.

ghost

I found one issue that needs attention before merge.

ghost · 2025-10-08T00:21:59Z

+		case "requireCtrlEnterToSend":
+			await updateGlobalState("requireCtrlEnterToSend", message.bool)
+			// No need to call postStateToWebview here as the UI already updated optimistically
+			break


[P1] Setting change doesn't propagate to the webview. The extension updates global state but doesn't notify the frontend, so Chat won't reflect the new behavior until a later state refresh. After updating, also post a message back to the webview so ExtensionStateContext can update immediately.

Suggested change

case "requireCtrlEnterToSend":

await updateGlobalState("requireCtrlEnterToSend", message.bool)

// No need to call postStateToWebview here as the UI already updated optimistically

break

case "requireCtrlEnterToSend":

await updateGlobalState("requireCtrlEnterToSend", message.bool)

await provider.postMessageToWebview({ type: "requireCtrlEnterToSend", bool: message.bool ?? false })

break

I am following the other UI checkbox; the other doesn't do this, so I believe this one shouldn't either.

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

ghost

I found some issues that need attention before merge.

ghost

I found some issues that need attention before merge.

lmtr0 · 2025-10-31T19:58:07Z

Understood, I'll take a look at this shortly

…ocode into feature/ctrl-enter-send

lmtr0 · 2025-11-01T21:20:02Z

I have addressed the feedback. What do you think of the current changes?

ghost · 2025-11-01T21:20:13Z

Found 1 critical issue remaining:

Critical Issues (Must Fix):

Fix Italian locale JSON structure - has duplicate description keys and missing closing brace for collapseThinking object causing JSON parsing errors

Recently Fixed:

French locale now correctly uses {primaryMod} placeholder (fixed in commit 0d538a9)
German locale uses {primaryMod} placeholder correctly

Previous Reviews

_{Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request.}

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

lmtr0 · 2025-11-03T19:12:46Z

@daniel-lxs any chance we can get this out?

ghost · 2025-11-03T19:17:15Z

 	"ui": {
 		"collapseThinking": {
 			"label": "Comprimi i messaggi di pensiero per impostazione predefinita",
-			"description": "Se abilitato, i blocchi di pensiero verranno compressi per impostazione predefinita finché non interagisci con essi"
+		"requireCtrlEnterToSend": {
+			"label": "Richiedi {primaryMod}+Invio per inviare messaggi",
+			"description": "Quando abilitato, devi premere {primaryMod}+Invio per inviare messaggi invece di solo Invio"
+			"description": "Quando abilitato, devi premere Ctrl+Invio per inviare messaggi invece di solo Invio"
 		}
 	}


[P0] Critical: Invalid JSON structure. The Italian locale file has malformed JSON with missing closing brace for collapseThinking object and duplicate description keys. This will cause JSON parsing errors and break the application.

Suggested change

"ui": {

"collapseThinking": {

"label": "Comprimi i messaggi di pensiero per impostazione predefinita",

"description": "Se abilitato, i blocchi di pensiero verranno compressi per impostazione predefinita finché non interagisci con essi"

"requireCtrlEnterToSend": {

"label": "Richiedi {primaryMod}+Invio per inviare messaggi",

"description": "Quando abilitato, devi premere {primaryMod}+Invio per inviare messaggi invece di solo Invio"

"description": "Quando abilitato, devi premere Ctrl+Invio per inviare messaggi invece di solo Invio"

}

}

"ui": {

"collapseThinking": {

"label": "Comprimi i messaggi di pensiero per impostazione predefinita",

"description": "Se abilitato, i blocchi di pensiero verranno compressi per impostazione predefinita finché non interagisci con essi"

},

"requireCtrlEnterToSend": {

"label": "Richiedi {primaryMod}+Invio per inviare messaggi",

"description": "Quando abilitato, devi premere {primaryMod}+Invio per inviare messaggi invece di solo Invio"

}

}

ghost · 2025-11-03T19:17:49Z

+		"requireCtrlEnterToSend": {
+			"label": "Erfordert {primaryMod}+Enter zum Senden von Nachrichten",
+			"description": "Wenn aktiviert, musst du {primaryMod}+Enter drücken, um Nachrichten zu senden, anstatt nur Enter."


[P2] Translation inconsistency: German locale still uses hardcoded "Strg+Enter" instead of the dynamic {primaryMod} placeholder. This causes incorrect key combination display for macOS users (should show "Cmd+Enter").

Suggested change

"requireCtrlEnterToSend": {

"label": "Erfordert {primaryMod}+Enter zum Senden von Nachrichten",

"description": "Wenn aktiviert, musst du {primaryMod}+Enter drücken, um Nachrichten zu senden, anstatt nur Enter."

"requireCtrlEnterToSend": {

"label": "Erfordert {primaryMod}+Enter zum Senden von Nachrichten",

"description": "Wenn aktiviert, musst du {primaryMod}+Enter drücken, um Nachrichten zu senden, anstatt nur Enter."

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

hannesrudolph · 2025-11-06T15:58:39Z

Opened follow-up PR to land fixes since the original is from a fork and not pushable here: #9078

hannesrudolph · 2025-11-06T15:59:07Z

Superseded by #9078

lmtr0 · 2025-11-06T18:44:15Z

Thank you

drzraf · 2025-12-16T13:59:31Z

Posted in the other issue (but this one has subscribers):

Whether Enter or Ctrl+Enter is used, Shift+Enter should never send the text: It's been consistently (and almost universally) considered as a way to insert a newline instead of validating.

(please reopen)

lmtr0 · 2025-12-16T21:52:52Z

cc @hannesrudolph

lmtr0 added 2 commits October 7, 2025 19:46

new: Ctrl+Enter to send message to chat draft

71ac954

fix(Ctrl+Enter to send): UI Setting now actually saves the setting

9d206cb

lmtr0 requested review from cte, jr and mrubens as code owners October 7, 2025 23:30

github-project-automation Bot added this to Roo Code Roadmap and Roo Code Roadmap Oct 7, 2025

github-project-automation Bot moved this to New in Roo Code Roadmap Oct 7, 2025

github-project-automation Bot moved this to Triage in Roo Code Roadmap Oct 7, 2025

dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. Enhancement New feature or request UI/UX UI/UX related or focused labels Oct 7, 2025

Merge branch 'main' into feature/ctrl-enter-send

4055525

ghost reviewed Oct 7, 2025

View reviewed changes

Comment thread webview-ui/src/components/chat/ChatTextArea.tsx Outdated

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 7, 2025

feat(Ctrl+Enter to send): translations for other languages

50f03f8

ghost reviewed Oct 7, 2025

View reviewed changes

Comment thread webview-ui/src/components/chat/ChatTextArea.tsx Outdated

Comment thread webview-ui/src/components/chat/ChatTextArea.tsx

lmtr0 added 3 commits October 7, 2025 21:00

feat(Ctrl+Enter to send): compatibility with macos

4821071

feat(Ctrl+Enter to send): added tests for setting

a370dd5

Merge branch 'feature/ctrl-enter-send' of https://github.com/lmtr0/ro…

4351df6

…ocode into feature/ctrl-enter-send

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 8, 2025

feat(Ctrl+Enter to send): added missing translations

33112b2

ghost reviewed Oct 8, 2025

View reviewed changes

Comment thread webview-ui/src/i18n/locales/en/settings.json Outdated

Comment thread webview-ui/src/i18n/locales/en/settings.json

ghost reviewed Oct 8, 2025

View reviewed changes

lmtr0 and others added 2 commits October 7, 2025 22:05

feat: add Cmd to label

abd20bc

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

fix(Ctrl+Enter to send): removing incorrect change from roomote

9422644

ghost reviewed Oct 8, 2025

View reviewed changes

Comment thread webview-ui/src/i18n/locales/de/settings.json Outdated

ghost reviewed Oct 8, 2025

View reviewed changes

Comment thread webview-ui/src/i18n/locales/de/settings.json Outdated

lmtr0 force-pushed the feature/ctrl-enter-send branch from f6e5d9b to 9422644 Compare October 9, 2025 02:29

hannesrudolph removed the PR - Needs Preliminary Review label Oct 30, 2025

lmtr0 added 2 commits November 1, 2025 18:18

refactor: addressing pr comments made in RooCodeInc#8556

0897c67

Merge branch 'feature/ctrl-enter-send' of https://github.com/lmtr0/ro…

5a83af3

…ocode into feature/ctrl-enter-send

ghost reviewed Nov 1, 2025

View reviewed changes

Comment thread webview-ui/src/i18n/locales/de/settings.json Outdated

ghost reviewed Nov 1, 2025

View reviewed changes

Comment thread webview-ui/src/i18n/locales/fr/settings.json Outdated

ghost reviewed Nov 1, 2025

View reviewed changes

Comment thread webview-ui/src/i18n/locales/it/settings.json Outdated

lmtr0 and others added 3 commits November 3, 2025 16:11

Update webview-ui/src/i18n/locales/de/settings.json

cad2e54

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

Update webview-ui/src/i18n/locales/it/settings.json

52c83bc

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

Update webview-ui/src/i18n/locales/fr/settings.json

a1c41ea

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

ghost reviewed Nov 3, 2025

View reviewed changes

Comment thread webview-ui/src/i18n/locales/fr/settings.json Outdated

Update webview-ui/src/i18n/locales/fr/settings.json

0d538a9

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>

hannesrudolph mentioned this pull request Nov 6, 2025

fix(webview): address PR #8556 feedback (platform-aware key hints, i18n fixes, follow-up focus) #9078

Closed

6 tasks

hannesrudolph closed this Nov 6, 2025

github-project-automation Bot moved this from New to Done in Roo Code Roadmap Nov 6, 2025

github-project-automation Bot moved this from PR [Changes Requested] to Done in Roo Code Roadmap Nov 6, 2025

hannesrudolph pushed a commit that referenced this pull request Nov 6, 2025

refactor: addressing pr comments made in #8556

f2eb51a

hannesrudolph pushed a commit that referenced this pull request Dec 6, 2025

refactor: addressing pr comments made in #8556

096d4ad

hannesrudolph mentioned this pull request Dec 11, 2025

feat: add toggle for Enter key behavior in chat input #10002

Merged

lmtr0 deleted the feature/ctrl-enter-send branch December 15, 2025 23:25

Uh oh!

Conversation

lmtr0 commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related GitHub Issue

Description

Test Procedure

Pre-Submission Checklist

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

lmtr0 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lmtr0 commented Oct 31, 2025

Uh oh!

lmtr0 commented Nov 1, 2025

Uh oh!

ghost commented Nov 1, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lmtr0 commented Nov 3, 2025

Uh oh!

ghost Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

ghost Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hannesrudolph commented Nov 6, 2025

Uh oh!

hannesrudolph commented Nov 6, 2025

Uh oh!

lmtr0 commented Nov 6, 2025

Uh oh!

drzraf commented Dec 16, 2025

Uh oh!

lmtr0 commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

lmtr0 commented Oct 7, 2025 •

edited

Loading

ghost commented Nov 1, 2025 •

edited by ghost

Loading