Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Revert "Exclude the ID from Roo reasoning details" - #9850

Merged
mrubens merged 1 commit into
mainfrom
revert-9847-exclude_id_from_roo_reasoning_details
Dec 5, 2025
Merged

Revert "Exclude the ID from Roo reasoning details"#9850
mrubens merged 1 commit into
mainfrom
revert-9847-exclude_id_from_roo_reasoning_details

Conversation

@mrubens

@mrubens mrubens commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator

Reverts #9847


Important

Reverts exclusion of id field from reasoning details in RooHandler in roo.ts.

  • Behavior:
    • Reverts exclusion of id field in reasoning details in RooHandler in roo.ts.
    • Updates createMessage() and createStream() to include id in reasoning details.
  • Misc:
    • Adds id field back to reasoning details object structure in roo.ts.

This description was created by Ellipsis for 1a8804a. You can customize this summary. It will automatically update as commits are pushed.

@mrubens
mrubens requested review from cte and jr as code owners December 5, 2025 03:13
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 5, 2025
@ghost

ghost commented Dec 5, 2025

Copy link
Copy Markdown

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

This revert correctly restores the id field to reasoning details, maintaining consistency with the OpenRouter implementation and the reasoning_details format specification. The id field is used to associate encrypted reasoning blocks with specific tool calls, which is important for proper tracking.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens
mrubens merged commit 7945860 into main Dec 5, 2025
@mrubens
mrubens deleted the revert-9847-exclude_id_from_roo_reasoning_details branch December 5, 2025 03:16
@github-project-automation github-project-automation Bot moved this from Triage to Done in Roo Code Roadmap Dec 5, 2025
@github-project-automation github-project-automation Bot moved this from New to Done in Roo Code Roadmap Dec 5, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants