Skip to content

Update README.md#610

Merged
SamProf merged 1 commit into
SamProf:developfrom
rokx:patch-1
Aug 2, 2020
Merged

Update README.md#610
SamProf merged 1 commit into
SamProf:developfrom
rokx:patch-1

Conversation

@rokx

@rokx rokx commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

Mentioned that internet access is required in Prerequisites.

Mentioned that internet access is required in Prerequisites.
@SamProf

SamProf commented Jul 5, 2020

Copy link
Copy Markdown
Owner

Hi, I am not sure that internet is required. Maybe only font's will have some problems. But this also can be resolved.

@rokx

rokx commented Jul 10, 2020

Copy link
Copy Markdown
Contributor Author

Look at
https://github.com/SamProf/MatBlazor/blob/master/src/MatBlazor/wwwroot/dist/matBlazor.css

You are referencing https://fonts.googleapis.com.

I would consider it a requirement.
These fonts are generated based on the client that is requesting them. It is not a trivial task of just downloading a font file.

@SamProf
SamProf changed the base branch from master to develop August 2, 2020 15:13
@SamProf
SamProf merged commit d28cf1d into SamProf:develop Aug 2, 2020
@SamProf

SamProf commented Aug 2, 2020

Copy link
Copy Markdown
Owner

Yeah, sure.
Maybe i need to think how I can integrate fonts to deployment. But for now you right - internet is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants