New asset commands - #36
Merged
Merged
Conversation
Contributor
There's no reason why we need to have JSON style input. It would make more sense to set these like you would with say environment variables in Docker (e.g. |
renatgalimov
approved these changes
Dec 29, 2022
…ommand can be used more than once to pass multiple headers.
Contributor
Author
Done though without short |
korvyashka
approved these changes
Dec 29, 2022
514sid
pushed a commit
to 514sid/cli
that referenced
this pull request
Jul 23, 2026
Resolve Dependabot alert Screenly#36 (GHSA-7gcf-g7xr-8hxj). Lockfile-only bump within the existing ^3.8.3 range; the advisory panic is in KeyValueMap, which this crate does not use, but the alert requires >= 3.21.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports
inject-jsandset-headerscommands for web assets.Inject-js allows setting JS injection code for web assets. Injected code will be executed during playback on the device once the asset is loaded.
set-headers similarly works on web assets setting values of custom HTTP headers.
Usage is a bit awkward but I did not come up with better syntax:
screenly asset set-headers 01FJVFP0QVD1E5TA70SA66AJPF --header k=v --header k2=v2Also adds
basic-authcommand that allows setting the basic auth header by accepting username and password.GitHub issue or Phabricator ticket number?
T6482
How has this been tested?
New unit tests + manual use.
Checklist before merging