feat: adopt Tailwind CSS utility classes for styling - #9
Draft
nicomiguelino wants to merge 1 commit into
Draft
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.htmlto use Tailwind utility classes instead of the custom CSS classes previously defined insrc/css/style.css, keeping visual appearance and behavior unchanged (pure refactor, not a redesign)..error-container,.error-message,.error-details,.error-key,.error-value) are preserved verbatim alongside the new Tailwind utility classes.tr:last-child td { border-bottom: none }rule is reproduced viagroupon<tr>+group-last:border-b-0on the<td>s (same technique used for position-based styling in the reference PRs).#embed-container iframe { border: 0 }descendant rule (targeting the iframe injected at runtime bypowerbi-client) is reproduced with the arbitrary variant[&_iframe]:border-0on#embed-container.src/css/style.cssdown to just the Tailwind layer/import setup (no app-specific CSS remains — the only custom styling was for the error screen, which used system font stacks already, so no@font-faceneeded to be preserved).@screenly/edge-appsto^1.3.0for upcoming Tailwind CSS support.This follows the same migration pattern applied in:
Test plan
bun run type-checkpassesbun run buildsucceeds (tested against a local unpublished@screenly/edge-apps@1.3.0tarball build with Tailwind support; the tarball install was fully reverted afterward — only the^1.3.0version bump inpackage.jsonis committed, and the lockfile is left untouched/stale until 1.3.0 is actually published, matching the reference PRs)dist/css/style.cssto confirm every arbitrary-value utility class used inindex.html(colors, px values,border-b,group-last:, the[&_iframe]:border-0variant, etc.) compiled to the expected CSS rules with correct values@playwright/testdependency, noscreenshots/directory, noedge-apps-scripts screenshotswiring, unlike clock-app/weather-app), so step could not be completed. Visual correctness was instead verified by manually cross-checking the compiled CSS output against the original CSS rule-by-rule.