feat: adopt Tailwind CSS utility classes for styling - #31
Draft
nicomiguelino wants to merge 1 commit into
Draft
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support. Regenerate screenshots to reflect the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.htmlto use Tailwind CSS utility classes instead of custom CSS classes, using arbitrary-value bracket syntax (text-[...],bg-[linear-gradient(...)],shadow-[...],border-[...],rounded-[...]) to reproduce exact px/rem/gradient/shadow values from the original design.src/main.ts(.feed-card-title,.feed-card-date,.feed-card-source,.feed-card-excerpt) alongside the new utility classes..feed-card:nth-child(n+4) { display: none }rule as a self-referential arbitrary variant (portrait:[&:nth-child(n+4)]:hidden) directly on the templated card element, and reproduces the[hidden]-attribute override behavior for#feed-grid/#feed-errorvia[&[hidden]]:hidden, so no JS changes were needed.src/css/style.cssdown to just the Tailwind layer setup (@layer theme, base, utilities+ the three imports), dropping all app-specific custom CSS now expressed as utilities. No@font-faceneeded — Inter is already provided by@screenly/edge-apps's base styles.@screenly/edge-appsto^1.3.0(unreleased version that will ship Tailwind CSS support) inpackage.json. The lockfile intentionally stays as committed (pointing at 1.0.0) until 1.3.0 is actually published — this matches how the reference PRs handled it.screenshots/*.webpfiles.This follows the same conversion pattern already applied to:
Note: this repo has no
developmentbranch (onlymain), so this PR targetsmaindirectly, per guidance from the migration coordinator.Test plan
bun run type-checkpassesbun run buildsucceeds (pre-existing unrelated Rolldownimport.meta/chunk-size warnings from@screenly/edge-apps's own bundled dev-tools/locale code, not caused by this change)bun run screenshots(Playwright) regenerated successfully for all configured resolutions, tested against a local unpublished@screenly/edge-apps@1.3.0tarball build (reverted afterwards; only thepackage.jsonversion bump was kept, lockfile untouched)