Skip to content

Add copy to clipboard tag - #5353

Merged
TheLimeGlass merged 4 commits into
SkriptLang:masterfrom
UnderscoreTud:feature/copy-to-clipboard
Feb 4, 2023
Merged

Add copy to clipboard tag#5353
TheLimeGlass merged 4 commits into
SkriptLang:masterfrom
UnderscoreTud:feature/copy-to-clipboard

Conversation

@UnderscoreTud

Copy link
Copy Markdown
Member

Description

This PR adds a copy to clipboard tag to Skript's chat components, this tag has been missing from the tags that Skript supports for a while now, and I don't see any reason on why that is.
Here's an example of how to use it:

send "<copy:text to copy>text to display"

Target Minecraft Versions: 1.15+
Requirements: none
Related Issues: #5351

@TheLimeGlass
TheLimeGlass self-requested a review January 15, 2023 00:20
@TheLimeGlass TheLimeGlass added the feature Pull request adding a new feature. label Jan 15, 2023
Comment thread src/main/resources/lang/default.lang

@AyhamAl-Ali AyhamAl-Ali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

Comment thread src/main/java/ch/njol/skript/util/chat/SkriptChatCode.java Outdated

@TheLimeGlass TheLimeGlass left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to have an update to the documentation at docs/text.html

@AyhamAl-Ali

Copy link
Copy Markdown
Member

Needs to have an update to the documentation at docs/text.html

This will have to be in the other repo https://github.com/SkriptLang/skript-docs/ so this should be good to go, another PR should be opened there either parallel or after both are okay

@TheLimeGlass
TheLimeGlass merged commit 8a96dcb into SkriptLang:master Feb 4, 2023
@UnderscoreTud
UnderscoreTud deleted the feature/copy-to-clipboard branch February 15, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Pull request adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants