Skip to content

BossBar Fixes - #8768

Merged
APickledWalrus merged 7 commits into
SkriptLang:dev/featurefrom
AnOwlBe:BossBarFixes
Jul 15, 2026
Merged

BossBar Fixes#8768
APickledWalrus merged 7 commits into
SkriptLang:dev/featurefrom
AnOwlBe:BossBarFixes

Conversation

@AnOwlBe

@AnOwlBe AnOwlBe commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Problem

Fixes & cleans up a few things

Solution

Fixed an issue where you could not delete a keyed boss bar when directly pairing it with the boss bar from key expression resulting in users having to set the boss bar from key to a var then use it
fixed by moving the deletion for keyed bars from BossBarClassInfo to KeyedBossBarClassInfo (not sure why it was in BossBarClassInfo to begin I think I just forgot about it after KeyedBossBarClassInfo was made)

Fixes an issue where an NPE was produced (a Skript internal error) when you tried to create a keyed bossbar and provided an empty var as the key

Fixes some shitty coding conventions I left in BossBarUtils (using c variable names and such)
Changed the SuppressWarnings("unchecked") annotation for ExprSecCreateBossBar to be only for init instead of suppressing needlessly for the entire class

Adds an example of making a keyed boss bar to examples of ExprSecCreateBossBar

Adds to the description of title/name of bossbar telling users that things like shadow sprites or fonts won't work due to a bukkit limitation

Testing Completed

Manual testing completed for the delete boss bar thing it now appears to work fine
2026-07-11_19 07 27

Supporting Information


Completes: none
Related: none
AI assistance: none

@AnOwlBe
AnOwlBe requested a review from a team as a code owner July 11, 2026 23:08
@AnOwlBe
AnOwlBe requested review from TheMug06 and erenkarakal and removed request for a team July 11, 2026 23:08
@skriptlang-automation skriptlang-automation Bot added the needs reviews A PR that needs additional reviews label Jul 14, 2026

@APickledWalrus APickledWalrus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to fix gradlew.bat

@APickledWalrus
APickledWalrus merged commit a109310 into SkriptLang:dev/feature Jul 15, 2026
13 checks passed
@AnOwlBe AnOwlBe mentioned this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs reviews A PR that needs additional reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants