Skip to content

Fix plural item aliases - #8790

Open
Abrightday166 wants to merge 1 commit into
SkriptLang:dev/patchfrom
Abrightday166:fix/plural-item-aliases
Open

Fix plural item aliases#8790
Abrightday166 wants to merge 1 commit into
SkriptLang:dev/patchfrom
Abrightday166:fix/plural-item-aliases

Conversation

@Abrightday166

@Abrightday166 Abrightday166 commented Jul 24, 2026

Copy link
Copy Markdown

Problem

Item aliases for items ending in 's' are semantically wrong in the plural: e.g. "Cobblestone Stairss" and "Ancient Debriss"

Solution

For generated aliases, check that the item name doesn't end with an 's' before adding the '¦s' plural marker.

Testing Completed

Tested on paper-26.1.2-74 fresh server.
Manual testing via effect commands:

BEFORE
Executing 'send items of player's inventory'
64 oak stairss
64 spruce stairss
64 birch stairss
64 jungle stairss

AFTER
Executing 'send items in player's inventory'
64 oak stairs
64 spruce stairs
64 birch stairs
64 jungle stairs

and confirmed that other items are unaffected by the change.

Supporting Information

I would have just made an issue but I didn't want to waste your time so you get to waste your time reading this pr instead.


Completes:

Related: none
AI assistance: none

@Abrightday166
Abrightday166 requested review from a team and sovdeeth as code owners July 24, 2026 06:16
@Abrightday166
Abrightday166 requested review from APickledWalrus and removed request for a team July 24, 2026 06:16
@sovdeeth
sovdeeth changed the base branch from master to dev/patch July 24, 2026 06:20
@skriptlang-automation skriptlang-automation Bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jul 27, 2026

@APickledWalrus APickledWalrus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to see a more robust solution that makes use of the plural utilities, such as

public static String toEnglishPlural(String word) {

I don't believe there is a direct method matching this use case, but you could add one.

@skriptlang-automation skriptlang-automation Bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broadcasting item stacks with 2 or more items adds an s at the end (seems intentional but it does cause issues)

4 participants