Fix plural item aliases - #8790
Open
Abrightday166 wants to merge 1 commit into
Open
Conversation
Abrightday166
requested review from
APickledWalrus
and removed request for
a team
July 24, 2026 06:16
sovdeeth
approved these changes
Jul 24, 2026
erenkarakal
approved these changes
Jul 24, 2026
APickledWalrus
requested changes
Jul 30, 2026
APickledWalrus
left a comment
Member
There was a problem hiding this comment.
I would prefer to see a more robust solution that makes use of the plural utilities, such as
I don't believe there is a direct method matching this use case, but you could add one.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Item aliases for items ending in 's' are semantically wrong in the plural: e.g. "Cobblestone Stairss" and "Ancient Debriss"
Solution
For generated aliases, check that the item name doesn't end with an 's' before adding the '¦s' plural marker.
Testing Completed
Tested on paper-26.1.2-74 fresh server.
Manual testing via effect commands:
and confirmed that other items are unaffected by the change.
Supporting Information
I would have just made an issue but I didn't want to waste your time so you get to waste your time reading this pr instead.
Completes:
Related: none
AI assistance: none