Touch-ups for https://github.com/pythonarcade/arcade/pull/1868 - #1
Merged
Snipy7374 merged 25 commits intoSep 8, 2023
Merged
Conversation
The latest version of PyRight is a little over zealous.. There where two flagged non-issues. One where it didn't realise that the code would escape early, and another which is all pyglets fault.
Dropdowm -> Dropdown 2 times
…readthedocs Fix rendering on readthedocs Upgrade sphinx Revert accidental upgrade of sitemap plugin that broke incremental rebuilds
…ng-codeblock Fix rendering issue in CONTRIBUTING.rst
To avoid CI breakages due to pyright releasing a new version, not caused by any of our code
…te-Issue Fixed PyRight issues.
…-pyright-version Lock pyright version
…arcade#1876) * Fix exception type when Window.show_view is passed a non-View * Include instance info in Window.show_view TypeError * Add check for TypeError from show_view in Window tests * Revert inclusion of full printout in show_view TypeError
Update index.rst (GUI menu Tutorial)
* Use PyGLenum per @cspotcode's suggestion * Remove use of literals * Move to arcade.gl.types * Import TypeAlias from typing_extensions since it's from 3.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Merge in recent changes from upstream to make sure merge will work. The extra PRs in this one will "vanish" once merged and look like this in your PR:
Include suggestions made by cspotcode and others
Make a tweak to
SpriteList.drawto support a filter tupleApply annotation replacements in the original PR scope