Skip to content

Feat/jcx/buildinfo - #77

Merged
jcxldn merged 9 commits into
masterfrom
feat/jcx/buildinfo
Jan 23, 2021
Merged

Feat/jcx/buildinfo#77
jcxldn merged 9 commits into
masterfrom
feat/jcx/buildinfo

Conversation

@aakatz3

@aakatz3 aakatz3 commented Jan 20, 2021

Copy link
Copy Markdown
Collaborator

Add in build info, save failing stuff from javadoc, general ci fixes


JCX's To-Do List

  • Add docs for new functions
  • Add getVersion()

@aakatz3
aakatz3 requested a review from a team as a code owner January 20, 2021 18:46
@aakatz3
aakatz3 requested a review from jcxldn January 20, 2021 18:46
@aakatz3 aakatz3 added the ci/cd label Jan 20, 2021
@aakatz3

aakatz3 commented Jan 20, 2021

Copy link
Copy Markdown
Collaborator Author

There should also be a creation of the gradle.properties file re-added in here!

Co-authored-by: Andrew Katz <aakatz3@gmail.com>
@jcxldn
jcxldn force-pushed the feat/jcx/buildinfo branch from 17e1a6e to 9ec21e9 Compare January 21, 2021 09:06
Co-authored-by: Andrew Katz <aakatz3@gmail.com>
@jcxldn
jcxldn force-pushed the feat/jcx/buildinfo branch from 9ec21e9 to 752daa8 Compare January 21, 2021 09:10
@codecov

codecov Bot commented Jan 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #77 (d393202) into master (3901a1d) will increase coverage by 0.18%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage     20.13%   20.32%   +0.18%     
- Complexity      107      111       +4     
============================================
  Files            64       64              
  Lines          2861     2869       +8     
  Branches        381      381              
============================================
+ Hits            576      583       +7     
- Misses         2270     2271       +1     
  Partials         15       15              
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/dumbdogdiner/stickyapi/StickyAPI.java 63.63% <62.50%> (+63.63%) 4.00 <3.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3901a1d...d393202. Read the comment docs.

@jcxldn jcxldn added dependencies Pull requests that update a dependency file feature New feature or request non-breaking labels Jan 21, 2021
@jcxldn
jcxldn marked this pull request as draft January 23, 2021 16:35
@jcxldn
jcxldn marked this pull request as ready for review January 23, 2021 17:21

@jcxldn jcxldn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good over here; waiting for someone else to review.

@jcxldn
jcxldn merged commit 8dbe85f into master Jan 23, 2021
@jcxldn
jcxldn deleted the feat/jcx/buildinfo branch January 24, 2021 20:26
@jcxldn jcxldn mentioned this pull request Jan 25, 2021
3 tasks
jcxldn added a commit that referenced this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd dependencies Pull requests that update a dependency file feature New feature or request non-breaking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants