Rewrite the configuration package (very basic for now) - #98
Merged
Conversation
jcxldn
added
dependencies
kokumaji
approved these changes
Mar 5, 2021
kokumaji
left a comment
kokumaji
left a comment
Contributor
There was a problem hiding this comment.
Maybe also add something like YamlProvider#reload()? Other than that, lgtm 👍
Waiting for opinions from others
kaylendog
self-requested a review
March 5, 2021 13:59
kaylendog
requested changes
Mar 5, 2021
Codecov Report
@@ Coverage Diff @@
## feat/jcx/major/modules-def #98 +/- ##
===============================================================
+ Coverage 23.19% 34.39% +11.20%
===============================================================
Files 73 63 -10
Lines 3126 2532 -594
Branches 426 286 -140
===============================================================
+ Hits 725 871 +146
+ Misses 2355 1597 -758
- Partials 46 64 +18
Continue to review full report at Codecov.
|
jcxldn
force-pushed
the
feat/modules-pr/config
branch
from
March 6, 2021 10:54
1b3f795 to
8401dd6
Compare
jcxldn
force-pushed
the
feat/modules-pr/config
branch
from
March 7, 2021 09:46
981453a to
32b638f
Compare
jcxldn
marked this pull request as ready for review
March 7, 2021 17:42
kaylendog
requested changes
Mar 13, 2021
kaylendog
left a comment
kaylendog
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, minor changes :3
| import org.junit.jupiter.api.TestInstance.Lifecycle; | ||
|
|
||
| @TestInstance(Lifecycle.PER_CLASS) | ||
| public class YamlProviderTest { |
Collaborator
There was a problem hiding this comment.
As mentioned above, a test that forces a concurrent read/write of the config to ensure that behaves as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.