Refmap remapping on modlauncher in dev

[Niko-sk2x]

Legacy FML agent has this code

Mixin/src/launchwrapper/java/org/spongepowered/asm/launch/platform/MixinPlatformAgentFMLLegacy.java

Lines 314 to 324 in 4585277

	private void injectRemapper() {
	try {
	MixinPlatformAgentAbstract.logger.debug("Creating FML remapper adapter: {}", MixinPlatformAgentFMLLegacy.FML_REMAPPER_ADAPTER_CLASS);
	Class<?> clFmlRemapperAdapter = Class.forName(MixinPlatformAgentFMLLegacy.FML_REMAPPER_ADAPTER_CLASS, true, Launch.classLoader);
	Method mdCreate = clFmlRemapperAdapter.getDeclaredMethod("create");
	IRemapper remapper = (IRemapper)mdCreate.invoke(null);
	MixinEnvironment.getDefaultEnvironment().getRemappers().add(remapper);
	} catch (Exception ex) {
	MixinPlatformAgentAbstract.logger.debug("Failed instancing FML remapper adapter, things will probably go horribly for notch-obf'd mods!");
	}
	}

and this allows remapping refmap to work. Modlauncher specific agent doesn't have an equivalent.

While this wouldn't allow mods using mixin to work in dev just by putting them into mods folder (because that's not supported at all), this should allow dependencies added with fg.deobf to work (since the dependency remaping uses this code https://github.com/MinecraftForge/InstallerTools/blob/9147fcae6e088daf02d31a01ce6724ce91361ffa/src/main/java/net/minecraftforge/installertools/SrgMcpRenamer.java#L99-L112 which would remap shadows and overwrites correctly).

[Mumfrey]

You're right this was an oversight when I was making the modlauncher agent, I had intended to do this once I figured out what mapping provider is available in modlauncher or fml but it slipped my mind. Thanks for opening an issue, will look into this.

[BloCamLimb]

This can be solved by adding Java system properties,

minecraft {
    runs {
        client {
            property 'mixin.env.remapRefMap', 'true'
            property 'mixin.env.refMapRemappingFile', "${projectDir}/build/createSrgToMcp/output.srg"
        }
    }
}

then re-run genIntellijRuns and refresh gradle project

[gingershaped]

The fix @BloCamLimb suggested doesn't work for me, and I can't figure out why.

build.gradle: https://gist.github.com/GingerIndustries/03efeaed0b2ced30c648c9c33d00df3a

[gingershaped]

I may be listing Supplementaries as a dependency wrong.

[GaeaKat]

This can be solved by adding Java system properties,

minecraft {
    runs {
        client {
            property 'mixin.env.remapRefMap', 'true'
            property 'mixin.env.refMapRemappingFile', "${projectDir}/build/createSrgToMcp/output.srg"
        }
    }
}

then re-run genIntellijRuns and refresh gradle project

It seems you also need to add those properties to the other runs in 1.18.2 I don't know about earlier ones. without them runData for datagen purposes failed.

[BloCamLimb]

This can be solved by adding Java system properties,

minecraft {
    runs {
        client {
            property 'mixin.env.remapRefMap', 'true'
            property 'mixin.env.refMapRemappingFile', "${projectDir}/build/createSrgToMcp/output.srg"
        }
    }
}

then re-run genIntellijRuns and refresh gradle project

It seems you also need to add those properties to the other runs in 1.18.2 I don't know about earlier ones. without them runData for datagen purposes failed.

Yes, you're right. Generally, you should also apply these to server and data. But if you add MixinGradle plugin, you don't need these setups.

[0-x-2-2]

The fix BloCamLimb suggested doesn't work for me, and I can't figure out why.

It won't work correctly if they don't use the same mappings, but that may not be the issue here anyways but that is something to note.