STAC-25466 tidy the Go workspace manifests - #448
Open
LouisParkin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies
inv tidyto the workspace. 256 files, allgo.mod/go.sum— no source, no CI, no config.Why
go.modat the repo root already requires the newer versions; the 100+ workspace sub-modules were never re-tidied after the gRPC bump, so their manifests still pin the previous ones. The gate added in #447 (Go module tidiness (go.mod / go.sum)) fails onmaintoday because of it.The drift is entirely propagation of what the root module already declares:
golang.org/x/sysgolang.org/x/netgolang.org/x/syncgolang.org/x/textgolang.org/x/cryptogo.opentelemetry.io/otel*google.golang.org/grpcNothing is being upgraded here. MVS across the workspace already resolves to the right-hand column at build time — this commit just records it in the manifests so
check-mod-tidyagrees.How the patch was generated
Not by hand and not locally. A throwaway job ran the repo's own
_go_only_tidyinside the pinnedgodepsCI image and uploaded the resultinggit diffas an artifact; that artifact is what is committed here. The job has been removed from the branch — the only thing left is the manifest change.inv tidydispatches to_bazel_tidywhenbazelis onPATH(it is, in that image), which also regeneratesBUILD.bazel/gazelle output and trips the repo'sXDG_CACHE_HOME-in-CI guard._go_only_tidyis thego work sync+ per-modulego mod tidypath thatcheck-mod-tidyactually verifies, so that is what was called.Validation
The real proof is this PR's own
Go module tidiness (go.mod / go.sum)check — it re-runsinv check-mod-tidyagainst the committed tree, which is exactly the condition that fails onmain.Jira: STAC-25466