Skip to content

STAC-25444: bump dependencies to eliminate CVEs - #157

Merged
craffit merged 1 commit into
mainfrom
STAC-25444-fix-cves
Jul 28, 2026
Merged

STAC-25444: bump dependencies to eliminate CVEs#157
craffit merged 1 commit into
mainfrom
STAC-25444-fix-cves

Conversation

@craffit

@craffit craffit commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

What

Bump vulnerable transitive dependencies to their fixed versions to eliminate all reported CVEs, and fix the CI linter failure so the change can actually merge.

Package From To CVEs
golang.org/x/net v0.45.0 v0.56.0 CVE-2026-25681, -27136, -33814, -39821, -25680, -42502, -42506, -46600
github.com/moby/spdystream v0.2.0 v0.5.1 CVE-2026-35469
golang.org/x/sys v0.36.0 v0.46.0 CVE-2026-39824
golang.org/x/text v0.29.0 v0.39.0 CVE-2026-56852

Why a new PR

This supersedes #156 (external contribution by @thbertoldi), which had the right dependency bumps but:

  1. The CI linter job failed. x/net v0.56.0 requires Go 1.25, so go.mod targets go 1.25.0. But the CI linter still ran golangci-lint v2.3.1, which is built with Go 1.24, producing:
    can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0).
    Fixed here by bumping golangci-lint v2.3.1 -> v2.9.0 (first release built with Go 1.25).
  2. The commit was unsigned. This PR is signed.

Changes

  • go.mod / go.sum: dependency bumps above; go directive 1.24.0 -> 1.25.0 (drops the pinned toolchain line). x/net also pulls x/sync, x/term, x/tools to compatible versions. Regenerated with go mod tidy.
  • .github/workflows/ci.yml: go-version 1.24.x -> 1.25.x across all jobs; golangci-lint v2.3.1 -> v2.9.0.

Verification (local)

  • go build ./... — clean
  • go test ./... — all pass
  • golangci-lint v2.9.0 run — 0 issues
  • govulncheck ./... — all four targeted dependency CVEs resolved (remaining findings are Go standard-library advisories tied to the local toolchain patch version, not these dependencies, and CI does not run govulncheck)

Credit to @thbertoldi for the original dependency bumps in #156.

Tracked in STAC-25444.

Bump x/net v0.56.0, moby/spdystream v0.5.1, x/sys v0.46.0, x/text v0.39.0
(requires go 1.25). Also bump golangci-lint v2.3.1 => v2.9.0 so the linter
can load config targeting go 1.25.
@craffit
craffit merged commit fc307f7 into main Jul 28, 2026
5 checks passed
@craffit
craffit deleted the STAC-25444-fix-cves branch July 28, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants