Production-hardening: fix README API mismatch, add buildable PlatformIO config, real CI - #1
Open
SuperInstance wants to merge 6 commits into
Open
Production-hardening: fix README API mismatch, add buildable PlatformIO config, real CI#1SuperInstance wants to merge 6 commits into
SuperInstance wants to merge 6 commits into
Conversation
added 6 commits
July 10, 2026 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
begin()argument order, three fabricated sensor-registration method names that don't exist. Fixed to matchsrc/openconstruct-esp32.hexactly.platformio.ini— none existed despite the README's own PlatformIO install instructions; a stale.gitignoreline was also actively excluding it from ever being committed.String::toLowerCase()returnsvoidin this Arduino core, but the code was assigning its result — this would not have compiled at all..github/workflows/ci.yml) runningpio run -e esp32devand compiling the test suite.Verification
pio run -e esp32dev: SUCCESS (real ESP32 toolchain build, not just code review)pio test -e test --without-uploading --without-testing: compiles clean🤖 Generated with a multi-agent hardening pass (kimi), independently verified before opening this PR.