Feature: add option to hide avatar story ring#183
Open
mvsrcdst wants to merge 1 commit into
Open
Conversation
mvsrcdst
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings.Stories.HideAvatarStoryRing(Settings -> Stories -> "Hide Avatar Story Ring") hides the story ring around avatars everywhereAvatarNoderenders one (chat list, archived chats, contacts/search, etc.)AvatarNodelazily subscribes to the setting only while it holds non-nilstoryStats, and filters the ring out on toggle without re-fetching dataChatAvatarNavigationNode) is untouched because that's already governed by the existing "Hide Stories" toggleScreenshots
Toggle "Hide Avatar Story Ring" in Settings -> Stories
Testing