[BootstrapAdminUi] General UI improvements - #159
Merged
Conversation
diimpp
approved these changes
Dec 12, 2024
diimpp
reviewed
Dec 12, 2024
| <td{% if field.options.vars.td_class is defined %} class="{{ field.options.vars.td_class }}"{% endif %}> | ||
| {{ sylius_grid_render_field(grid, field, row) }} | ||
| {% if field.name == 'code' %} | ||
| <code>{{ sylius_grid_render_field(grid, field, row) }}</code> |
Member
There was a problem hiding this comment.
if it was regular twig render, then styling of the field should have been done via theme, but guess it's not applicable over here.
Member
Author
There was a problem hiding this comment.
Indeed, interesting comment. For now, I prefer keeping admin-bundle and bootstrap-admin-ui synced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157