[TASK] Backport of #726#729
Merged
Merged
Conversation
In order to prepare for guzzlehttp/guzzle v8 in TYPO3 core, we allow the installation of the `guzzlehttp/psr7` helper package. composer req guzzlehttp/psr7:"^2.5.0 || ^3.0" Releases: main, 9, 8
ComposerPackageManager::getPackageComposerJson() passed the JSON_THROW_ON_ERROR constant as the third argument of json_decode(), which is $depth, leaving $flags at its default value 0. The flag therefore never took effect: malformed composer.json content did not raise a JsonException, which turned the surrounding try/catch block into dead code, while $depth was set to the constant value 4194304. The call now uses the default depth of 512 and passes the flag in the $flags argument, so decoding errors are handled as originally intended. Observable behaviour does not change, since json_decode() returns null for invalid input, which already matched the intended null fallback of the method. PHPStan 2.2 reports the previous call as argument.invalidConstant. As composer.lock is not part of the repository, CI resolves the latest PHPStan release, which turned this into a failing quality gate on the PHP 8.2 and 8.3 jobs. Releases: main, 9, 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to prepare for guzzlehttp/guzzle v8 in
TYPO3 core, we allow the installation of the
guzzlehttp/psr7helper package.composer req guzzlehttp/psr7:"^2.5.0 || ^3.0"
Releases: main, 9, 8