Skip to content

fix(create): report Intent as skipped when --no-install is used - #496

Open
Mohith26 wants to merge 2 commits into
TanStack:mainfrom
Mohith26:fix/create-no-install-intent-agents-md
Open

fix(create): report Intent as skipped when --no-install is used#496
Mohith26 wants to merge 2 commits into
TanStack:mainfrom
Mohith26:fix/create-no-install-intent-agents-md

Conversation

@Mohith26

@Mohith26 Mohith26 commented Jul 29, 2026

Copy link
Copy Markdown

Fixes #495, reported by @shivss26.

create --no-install printed "TanStack Intent configured" and the outro claimed the agent config "was wired up", but no AGENTS.md exists: setupIntent runs @tanstack/intent install --map, which discovers skills by walking installed node_modules, so with nothing installed it writes nothing.

Actually writing AGENTS.md without installing is not feasible from this repo (@tanstack/intent is external and needs packages on disk), so this makes the reporting honest instead: create-app and edge-create-app now skip the Intent step when install === false, print "TanStack Intent setup skipped: no dependencies installed yet", and the next-steps output shows the exact package-manager-aware follow-up (pnpm install, then pnpm dlx @tanstack/intent install --map).

Five regression tests cover the skip behavior, the outro text, and the unchanged installed-path behavior. packages/create: 253 passed; packages/cli: 101 passed; zero new failures.

Summary by CodeRabbit

  • New Features

    • TanStack Intent setup now respects the dependency installation option.
    • When installation is skipped, setup is deferred and clear commands are provided for completing it later.
    • Next-step guidance now accurately reflects whether Intent configuration was completed or skipped.
  • Bug Fixes

    • Prevented Intent setup commands from running when dependencies are not installed.

Mohith26 added 2 commits July 28, 2026 19:31
TanStack Intent discovers skills by walking installed node_modules, so
running `@tanstack/intent install --map` in a project scaffolded with
--no-install finds nothing and writes no AGENTS.md, while the CLI still
reported 'TanStack Intent configured' and the closing next steps claimed
the agent config 'was wired up'.

Skip the Intent step when dependency installation is skipped, report it
as skipped, and point the next steps at the follow-up commands to run
after installing dependencies.

Fixes TanStack#495
Add regression tests for TanStack#495: setupIntent must not run the intent
install command when dependency installation is skipped, and the
closing next steps must report the skip with follow-up commands
instead of claiming the agent config was wired up.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

TanStack Intent setup now skips execution when dependency installation is disabled. App creation output provides follow-up install and mapping commands, while installed flows retain the existing configuration message. Tests cover both command execution and generated completion text.

Changes

TanStack Intent setup reporting

Layer / File(s) Summary
Guard Intent setup when installs are disabled
packages/create/src/edge-create-app.ts, packages/create/src/integrations/intent.ts
Intent setup reports that it was skipped when dependencies are not installed and continues issuing the mapping command otherwise.
Align next-step messages with setup state
packages/create/src/create-app.ts, packages/create/src/edge-create-app.ts
Next-step output conditionally includes dependency installation and Intent mapping commands, while preserving the wired-up message for installed flows.
Validate skipped and installed Intent flows
packages/create/tests/create-app.test.ts, packages/create/tests/integrations/intent.test.ts
Tests verify command absence or presence and the corresponding completion messages across Intent and installation options.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CreateApp
  participant SetupIntent
  participant PackageManager
  participant NextSteps
  CreateApp->>SetupIntent: configure TanStack Intent
  alt install is false
    SetupIntent-->>CreateApp: report skipped setup
    CreateApp->>NextSteps: add install and mapping commands
  else install is true
    SetupIntent->>PackageManager: run Intent mapping command
    PackageManager-->>SetupIntent: command result
    CreateApp->>NextSteps: add wired-up configuration message
  end
Loading

Suggested reviewers: tannerlinsley

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: reporting TanStack Intent as skipped when --no-install is used.
Linked Issues check ✅ Passed The PR satisfies #495 by skipping Intent setup without installs, removing the wired-up claim, adding follow-up commands, and preserving installed behavior.
Out of Scope Changes check ✅ Passed The changes stay focused on the no-install Intent reporting flow and its tests, with no obvious unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/create/tests/create-app.test.ts

Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser.
The file was not found in any of the provided project(s): packages/create/tests/create-app.test.ts

packages/create/tests/integrations/intent.test.ts

Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser.
The file was not found in any of the provided project(s): packages/create/tests/integrations/intent.test.ts


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/create/src/edge-create-app.ts (1)

259-270: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add regression coverage for the edge flow.

edge-create-app.ts defines its own setupIntent branch for options.install === false, but the existing coverage only hits the shared integration test and createApp no-install behavior. Add equivalent --no-install and installed-path coverage for edge-create-app.ts so this branch cannot regress independently.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/create/src/edge-create-app.ts` around lines 259 - 270, Add
regression tests targeting edge-create-app.ts's setupIntent flow: verify the
--no-install path skips TanStack Intent setup with the expected step messages,
and verify the installed path performs setup as expected. Keep these cases
specific to the edge create-app flow rather than relying only on shared
integration or createApp coverage.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/create/src/edge-create-app.ts`:
- Around line 259-270: Add regression tests targeting edge-create-app.ts's
setupIntent flow: verify the --no-install path skips TanStack Intent setup with
the expected step messages, and verify the installed path performs setup as
expected. Keep these cases specific to the edge create-app flow rather than
relying only on shared integration or createApp coverage.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8cf247af-cb28-426c-85eb-8d210e3e16cc

📥 Commits

Reviewing files that changed from the base of the PR and between efbc8d5 and c72113b.

📒 Files selected for processing (5)
  • packages/create/src/create-app.ts
  • packages/create/src/edge-create-app.ts
  • packages/create/src/integrations/intent.ts
  • packages/create/tests/create-app.test.ts
  • packages/create/tests/integrations/intent.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create --no-install reports "TanStack Intent configured" but writes no AGENTS.md

1 participant