fix(create): report Intent as skipped when --no-install is used - #496
fix(create): report Intent as skipped when --no-install is used#496Mohith26 wants to merge 2 commits into
Conversation
TanStack Intent discovers skills by walking installed node_modules, so running `@tanstack/intent install --map` in a project scaffolded with --no-install finds nothing and writes no AGENTS.md, while the CLI still reported 'TanStack Intent configured' and the closing next steps claimed the agent config 'was wired up'. Skip the Intent step when dependency installation is skipped, report it as skipped, and point the next steps at the follow-up commands to run after installing dependencies. Fixes TanStack#495
Add regression tests for TanStack#495: setupIntent must not run the intent install command when dependency installation is skipped, and the closing next steps must report the skip with follow-up commands instead of claiming the agent config was wired up.
📝 WalkthroughWalkthroughTanStack Intent setup now skips execution when dependency installation is disabled. App creation output provides follow-up install and mapping commands, while installed flows retain the existing configuration message. Tests cover both command execution and generated completion text. ChangesTanStack Intent setup reporting
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CreateApp
participant SetupIntent
participant PackageManager
participant NextSteps
CreateApp->>SetupIntent: configure TanStack Intent
alt install is false
SetupIntent-->>CreateApp: report skipped setup
CreateApp->>NextSteps: add install and mapping commands
else install is true
SetupIntent->>PackageManager: run Intent mapping command
PackageManager-->>SetupIntent: command result
CreateApp->>NextSteps: add wired-up configuration message
end
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/create/tests/create-app.test.tsParsing error: "parserOptions.project" has been provided for packages/create/tests/integrations/intent.test.tsParsing error: "parserOptions.project" has been provided for Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/create/src/edge-create-app.ts (1)
259-270: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd regression coverage for the edge flow.
edge-create-app.tsdefines its ownsetupIntentbranch foroptions.install === false, but the existing coverage only hits the shared integration test andcreateAppno-install behavior. Add equivalent--no-installand installed-path coverage foredge-create-app.tsso this branch cannot regress independently.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/create/src/edge-create-app.ts` around lines 259 - 270, Add regression tests targeting edge-create-app.ts's setupIntent flow: verify the --no-install path skips TanStack Intent setup with the expected step messages, and verify the installed path performs setup as expected. Keep these cases specific to the edge create-app flow rather than relying only on shared integration or createApp coverage.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/create/src/edge-create-app.ts`:
- Around line 259-270: Add regression tests targeting edge-create-app.ts's
setupIntent flow: verify the --no-install path skips TanStack Intent setup with
the expected step messages, and verify the installed path performs setup as
expected. Keep these cases specific to the edge create-app flow rather than
relying only on shared integration or createApp coverage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8cf247af-cb28-426c-85eb-8d210e3e16cc
📒 Files selected for processing (5)
packages/create/src/create-app.tspackages/create/src/edge-create-app.tspackages/create/src/integrations/intent.tspackages/create/tests/create-app.test.tspackages/create/tests/integrations/intent.test.ts
Fixes #495, reported by @shivss26.
create --no-installprinted "TanStack Intent configured" and the outro claimed the agent config "was wired up", but no AGENTS.md exists:setupIntentruns@tanstack/intent install --map, which discovers skills by walking installednode_modules, so with nothing installed it writes nothing.Actually writing AGENTS.md without installing is not feasible from this repo (
@tanstack/intentis external and needs packages on disk), so this makes the reporting honest instead:create-appandedge-create-appnow skip the Intent step wheninstall === false, print "TanStack Intent setup skipped: no dependencies installed yet", and the next-steps output shows the exact package-manager-aware follow-up (pnpm install, thenpnpm dlx @tanstack/intent install --map).Five regression tests cover the skip behavior, the outro text, and the unchanged installed-path behavior. packages/create: 253 passed; packages/cli: 101 passed; zero new failures.
Summary by CodeRabbit
New Features
Bug Fixes