-
-
Notifications
You must be signed in to change notification settings - Fork 181
Use intent discovery mode instead of inlining the skill map into AGENTS.md #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WaryaWayne
wants to merge
3
commits into
TanStack:main
Choose a base branch
from
WaryaWayne:fix/intent-skill-mappings-context-cost
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| '@tanstack/create': patch | ||
| --- | ||
|
|
||
| Wire TanStack Intent up in on-demand discovery mode instead of writing the full | ||
| skill-to-task mapping table into `AGENTS.md`. Generated projects previously got | ||
| an `install --map` block listing every skill for every installed package — 99 | ||
| lines in a default app, growing with each add-on — which every agent re-read on | ||
| every invocation. Plain `install` emits a 10-line pointer telling the agent to | ||
| run `intent list` and `intent load <package>#<skill>` when a task actually calls | ||
| for one. The "next steps" output now shows those two commands, rendered for the | ||
| project's package manager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: TanStack/cli
Length of output: 5169
🏁 Script executed:
Repository: TanStack/cli
Length of output: 50368
🌐 Web query:
TanStack Intent Deno npm interop node_modules support deno run npm:💡 Result:
Deno provides native support for npm packages, including TanStack libraries, through npm specifiers (e.g., npm:
@tanstack/react-query) [1][2][3]. You do not need a node_modules directory by default [1][2][4]. NPM Interop and node_modules Support: - Default Behavior: By default, Deno resolves npm packages from a central global cache, which keeps your project directory clean and avoids the creation of a node_modules folder [5][6][4]. - Opt-in node_modules: Some packages or tools (like certain bundlers) require a node_modules directory [6][7][4]. You can enable this behavior by setting "nodeModulesDir": "auto" in your deno.json configuration file or by using the --node-modules-dir flag when running commands [8][6][7]. - Running with npm: When using npm specifiers (e.g., deno run npm:package), Deno automatically handles the download and resolution of dependencies [1][4]. If you have a package.json file present in your project, Deno defaults to creating a local node_modules directory, though this can be controlled via configuration [6][2][9]. TanStack Support: - TanStack libraries are fully compatible with Deno's npm specifier system [3][10]. Official Deno documentation and community contributions confirm that you can install and use packages like@tanstack/react-querydirectly via deno install npm:@tanstack/react-queryor by referencing them in your imports [3][10]. Summary of Configuration: - To use npm packages without node_modules: Use the default Deno behavior (no extra configuration needed) [5][4]. - To force node_modules creation: Set "nodeModulesDir": "auto" in deno.json [6][7]. - For existing Node.js projects: You can run them in Deno by referencing dependencies in package.json and optionally setting the node_modules mode to manual or auto depending on your requirements [5][6][4].Citations:
🌐 Web query:
TanStack Intent Deno Deno.run permissions --allow-net allow-env allow-read💡 Result:
TanStack Intent is a CLI tool designed to ship and consume AI agent skills via npm packages [1][2]. While TanStack Intent lists Deno as a supported environment, it currently operates on a best-effort basis requiring npm interop with node_modules support enabled [3][4]. Regarding your query on Deno APIs and permissions: 1. Deno.run Deprecation: The Deno.run API is deprecated and has been soft-removed in Deno 2 [5][6]. You should replace it with the Deno.Command API [5][7]. - Example migration: // Instead of Deno.run const process = new Deno.Command("command_name", { args: ["arg1"], stdout: "piped", }); const { success, stdout } = await process.output; 2. Deno Permissions: To use APIs that require net, env, read, or run access, you must explicitly grant these permissions at runtime using command-line flags [8][9]. - Flag usage: - --allow-net: Grants network access (can be scoped to specific hosts) [8][10]. - --allow-env: Grants access to environment variables (can be scoped to specific variables) [8][10]. - --allow-read: Grants file system read access (can be scoped to specific paths) [8][10]. - --allow-run: Required for executing subprocesses, such as when using Deno.Command [8][11]. To grant all these permissions at once for a script, you can use: deno run --allow-net --allow-env --allow-read --allow-run script.ts For stricter security, it is highly recommended to scope these permissions (e.g., --allow-read=./data or --allow-net=example.com) rather than granting full access [9].
Citations:
Add explicit Deno guidance for TanStack Intent.
intentCommandreturnsdeno run npm:@tanstack/intent..., which works with Deno npm specifiers, but TanStack Intent documents Deno as best-effort and requiring npm interop withnode_modulessupport. Add install/create guidance that Deno needsnodeModulesDir: "auto"indeno.jsonor--node-modules-dir/--allow-install, and any permissions the Deno CLI may need.🤖 Prompt for AI Agents
Source: MCP tools