Skip to content

stop pushing down where clauses that match a select projection in a subquery - #654

Merged
samwillis merged 3 commits into
mainfrom
samwillis/join-nested-where-bug
Oct 9, 2025
Merged

stop pushing down where clauses that match a select projection in a subquery#654
samwillis merged 3 commits into
mainfrom
samwillis/join-nested-where-bug

Conversation

@samwillis

Copy link
Copy Markdown
Collaborator

we will want to revisit this in a future refactor

@samwillis
samwillis requested a review from kevin-dp October 7, 2025 13:23
@changeset-bot

changeset-bot Bot commented Oct 7, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8a4a41f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@tanstack/db Patch
@tanstack/angular-db Patch
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/react-db Patch
@tanstack/rxdb-db-collection Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch
todos Patch
@tanstack/db-example-react-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 7, 2025

Copy link
Copy Markdown
More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@654

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@654

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@654

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@654

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@654

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@654

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@654

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@654

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@654

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@654

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@654

commit: 8a4a41f

@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Size Change: +179 B (+0.23%)

Total Size: 76.9 kB

Filename Size Change
./packages/db/dist/esm/query/optimizer.js 3.26 kB +179 B (+5.81%) 🔍
ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/collection/change-events.js 963 B
./packages/db/dist/esm/collection/changes.js 1.01 kB
./packages/db/dist/esm/collection/events.js 660 B
./packages/db/dist/esm/collection/index.js 3.31 kB
./packages/db/dist/esm/collection/indexes.js 1.16 kB
./packages/db/dist/esm/collection/lifecycle.js 1.8 kB
./packages/db/dist/esm/collection/mutations.js 2.52 kB
./packages/db/dist/esm/collection/state.js 3.79 kB
./packages/db/dist/esm/collection/subscription.js 1.83 kB
./packages/db/dist/esm/collection/sync.js 1.68 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 3.1 kB
./packages/db/dist/esm/index.js 1.58 kB
./packages/db/dist/esm/indexes/auto-index.js 794 B
./packages/db/dist/esm/indexes/base-index.js 835 B
./packages/db/dist/esm/indexes/btree-index.js 2 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.21 kB
./packages/db/dist/esm/indexes/reverse-index.js 577 B
./packages/db/dist/esm/local-only.js 967 B
./packages/db/dist/esm/local-storage.js 2.33 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 3.86 kB
./packages/db/dist/esm/query/builder/functions.js 615 B
./packages/db/dist/esm/query/builder/index.js 4.04 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 938 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.55 kB
./packages/db/dist/esm/query/compiler/expressions.js 760 B
./packages/db/dist/esm/query/compiler/group-by.js 2.04 kB
./packages/db/dist/esm/query/compiler/index.js 2.04 kB
./packages/db/dist/esm/query/compiler/joins.js 2.52 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.21 kB
./packages/db/dist/esm/query/compiler/select.js 1.28 kB
./packages/db/dist/esm/query/ir.js 785 B
./packages/db/dist/esm/query/live-query-collection.js 340 B
./packages/db/dist/esm/query/live/collection-config-builder.js 3.03 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 1.92 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 3 kB
./packages/db/dist/esm/utils.js 1.01 kB
./packages/db/dist/esm/utils/browser-polyfills.js 365 B
./packages/db/dist/esm/utils/btree.js 6.01 kB
./packages/db/dist/esm/utils/comparison.js 754 B
./packages/db/dist/esm/utils/index-optimization.js 1.73 kB

compressed-size-action::db-package-size

@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 1.46 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.31 kB

compressed-size-action::react-db-package-size

@kevin-dp kevin-dp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few minor comments and questions.

Comment thread packages/db/src/query/optimizer.ts Outdated
Comment thread packages/db/src/query/optimizer.ts Outdated
Comment thread packages/db/src/query/optimizer.ts Outdated
Comment thread packages/db/src/query/optimizer.ts
@samwillis
samwillis merged commit 4a7c44a into main Oct 9, 2025
6 checks passed
@samwillis
samwillis deleted the samwillis/join-nested-where-bug branch October 9, 2025 16:26
@github-actions github-actions Bot mentioned this pull request Oct 9, 2025
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR has been released!

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants