-
-
Notifications
You must be signed in to change notification settings - Fork 93
feat(devtools): add floating/draggable trigger with throw physics #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| '@tanstack/devtools': minor | ||
| --- | ||
|
|
||
| Add a floating trigger mode. Set `triggerMode: 'floating'` (or choose it under | ||
| Settings → Trigger Mode) to drag the devtools trigger anywhere on screen with | ||
| the left mouse button. Releasing a drag with velocity throws it — it glides with | ||
| momentum and springs back off the screen edges. The trigger is always kept | ||
| within a padded, on-screen area (it can never end up off-screen) and its | ||
| position is persisted to local storage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🌐 Web query:
does a click event fire after pointercancel💡 Result:
A click event does not fire after a pointercancel event [1][2][3]. The pointercancel event is specifically designed to signal that the pointer event stream has been suppressed or interrupted (for example, by browser-initiated actions like scrolling, panning, or system-level gestures) [1][2][4]. Because the pointer interaction has been canceled, the browser treats the interaction as incomplete and does not proceed to fire the compatibility mouse events (such as mousedown, mouseup, or click) that would normally conclude a completed pointer sequence [5][2][4]. According to the W3C Pointer Events specification, the pointercancel event is followed by pointerout and pointerleave events to signify the end of the interaction for that pointer [1][2][3].
Citations:
userEventto considerclick/auxclickevent target aftertouchend(orpointerup) w3c/pointerevents#508🏁 Script executed:
Repository: TanStack/devtools
Length of output: 4166
🏁 Script executed:
Repository: TanStack/devtools
Length of output: 693
Reset
movedonpointercancelA canceled drag that crossed the threshold leaves
movedstucktrue, and no click follows to clear it. Reset it in the cancel path so the next genuine click still toggles.🤖 Prompt for AI Agents