fix: create fieldMeta on async validation for fields with errors by literalpie · Pull Request #2056 · TanStack/form

literalpie · 2026-03-02T18:28:46Z

🎯 Changes

This updates the validateAsync function to have similar logic to validateSync. See #1691 where this logic was added to validateSync.

This makes it so that if async validation results in errors, any fields with errors will have a fieldMeta created

Fixes #2033

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Bug Fixes
- Fixed async validation so field metadata is created/updated for fields that have errors returned from async form validation, even when metadata wasn’t previously initialized.
- Improved how per-field async validation merges error information, ensuring error messages are correctly reflected in field-level metadata.
Tests
- Added coverage to verify { fields: ... } async submission errors are converted into the expected field metadata entries.

This updates the validateAsync function to have similar logic to validateSync. See TanStack#1691 where this logic was added to validateSync. Fixes TanStack#2033

changeset-bot · 2026-03-02T18:28:52Z

🦋 Changeset detected

Latest commit: 0868ac1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@tanstack/form-core	Patch
@tanstack/angular-form	Patch
@tanstack/form-devtools	Patch
@tanstack/lit-form	Patch
@tanstack/react-form	Patch
@tanstack/solid-form	Patch
@tanstack/svelte-form	Patch
@tanstack/vue-form	Patch
@tanstack/react-form-devtools	Patch
@tanstack/solid-form-devtools	Patch
@tanstack/react-form-nextjs	Patch
@tanstack/react-form-remix	Patch
@tanstack/react-form-start	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…dation-unmounted

coderabbitai · 2026-06-11T21:42:16Z

📝 Walkthrough

Walkthrough

This PR fixes async validation so fields that only receive form-level async errors still get fieldMeta created. It also adds a test covering submit-time async validation output shaped as { fields: ... }.

Changes

Fix fieldMeta creation during async validation

Layer / File(s)	Summary
Async validation field meta initialization `packages/form-core/src/FormApi.ts`, `.changeset/shy-otters-give.md`	`validateAsync` now processes field names from both existing `fieldMeta` keys and `fieldErrorsFromFormValidators`, skips only when neither meta nor errors exist, and initializes missing meta from `defaultFieldMeta` before merging error maps. A changeset entry records the patch release note.
Test async form submit validation fieldMeta creation `packages/form-core/tests/FormApi.spec.ts`	New async submit-validation test verifies a `{ fields: ... }` error result creates `fieldMeta.age` and sets `errorMap.onSubmit` after `handleSubmit()` and timer advancement.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant FormApi
  participant onSubmitAsync
  participant fieldMeta

  FormApi->>onSubmitAsync: run async submit validation
  onSubmitAsync-->>FormApi: return { fields: { age: error } }
  FormApi->>FormApi: include fieldErrorsFromFormValidators in field list
  FormApi->>fieldMeta: create/update age meta with errorMap.onSubmit

Suggested reviewers: crutchcorn

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR directly addresses issue `#2033` by implementing the expected behavior where async validation creates fieldMeta for affected fields, matching synchronous validation behavior.
Out of Scope Changes check	✅ Passed	All changes are scoped to the async validation fix: a changeset entry, FormApi.ts logic updates, and corresponding test coverage with no unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly matches the main change: creating fieldMeta during async validation for fields with errors.
Description check	✅ Passed	The description follows the template with Changes, Checklist, and Release Impact sections filled in.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

literalpie · 2026-06-11T21:53:24Z

@crutchcorn I hate to be the guy who pings the OSS maintainer, but I really think this fix is worth getting merged. We've been using a patch of this change for a few months in our large app without issue. Please let me know if there's anything I can do to help.

Based on reactions and commit references on this PR and the issue, I think it would benefit others too.

nx-cloud · 2026-07-09T09:36:46Z

View your CI Pipeline Execution ↗ for commit af28b12

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 18s	View ↗
`nx run-many --target=build --exclude=examples/**`	✅ Succeeded	40s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-09 09:53:20 UTC

# Conflicts: # packages/form-core/tests/FormApi.spec.ts

pkg-pr-new · 2026-07-09T09:38:17Z

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@2056

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@2056

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@2056

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@2056

@tanstack/preact-form

npm i https://pkg.pr.new/@tanstack/preact-form@2056

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@2056

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@2056

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@2056

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@2056

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@2056

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@2056

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@2056

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@2056

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@2056

commit: 1fd754f

…d field (#2233) * fix(form-core): guard FormGroupApi.distributeFieldErrors against unmounted field meta FormGroupApi.distributeFieldErrors called setFieldMeta with an updater that unconditionally spread prev, which is undefined when a group validator returns fields errors for a sub-field with no fieldMetaBase entry yet. Apply the same (prev = defaultFieldMeta) guard already used in FormApi's form-level field-error fan-out (see #1706, #2056). Fixes #2231 * chore: add changeset for #2231 --------- Co-authored-by: Corbin Crutchley <git@crutchcorn.dev>

codecov-commenter · 2026-07-09T09:54:36Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (6892ed0) to head (1fd754f).
⚠️ Report is 247 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
- Coverage   90.35%   89.72%   -0.63%     
==========================================
  Files          38       65      +27     
  Lines        1752     3203    +1451     
  Branches      444      809     +365     
==========================================
+ Hits         1583     2874    +1291     
- Misses        149      295     +146     
- Partials       20       34      +14

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

literalpie added 2 commits March 2, 2026 11:54

fix: async validation for unmounted fields

64f890b

This updates the validateAsync function to have similar logic to validateSync. See TanStack#1691 where this logic was added to validateSync. Fixes TanStack#2033

add changeset

0868ac1

literalpie mentioned this pull request Mar 2, 2026

fieldMeta not set by async validator #2033

Closed

Merge remote-tracking branch 'origin/main' into literalpie/async-vali…

af28b12

…dation-unmounted

Todomir mentioned this pull request Jul 2, 2026

FormGroup validator returning sub-field errors for unmounted fields throws "Cannot read properties of undefined (reading 'errorMap')" #2231

Closed

momomuchu mentioned this pull request Jul 4, 2026

fix(form-core): don't throw when a group validator errors an unmounted field #2233

Merged

Merge branch 'main' into literalpie/async-validation-unmounted

b6c8e1b

# Conflicts: # packages/form-core/tests/FormApi.spec.ts

ci: apply automated fixes and generate docs

1fd754f

crutchcorn merged commit 6cd477a into TanStack:main Jul 9, 2026
8 of 9 checks passed

github-actions Bot mentioned this pull request Jul 9, 2026

ci: Version Packages #2237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: create fieldMeta on async validation for fields with errors - #2056

fix: create fieldMeta on async validation for fields with errors#2056
crutchcorn merged 5 commits into
TanStack:mainfrom
literalpie:literalpie/async-validation-unmounted

literalpie commented Mar 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Mar 2, 2026

Uh oh!

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

literalpie commented Jun 11, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

literalpie commented Mar 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Mar 2, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

literalpie commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jul 9, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

literalpie commented Mar 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

literalpie commented Jun 11, 2026 •

edited

Loading

nx-cloud Bot commented Jul 9, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 9, 2026 •

edited

Loading