[WIP] fix: fix issues with Vue's typings in SFC format - #816
Closed
crutchcorn wants to merge 2 commits into
Closed
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c6f0f74. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
Member
Author
|
Closing, as much of this work has been now finished in #1104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As vuejs/language-tools#3782 was solved in Vue 3.4, we're marking Vue 3.4 as the minimum supported version for our Vue adapter
I'm having problems getting
defineComponenttypings working for both Vue SFC formats and JSX formats alike.The first commit in this PR works for JSX formats but not SFC formats
The second commits in this PR works for SFC formats but not JSX formats