canSubmit with onMount validators - #909
Closed
oscartbeaumont wants to merge 1 commit into
Closed
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 39e9fa3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 91.55% 88.55% -3.00%
==========================================
Files 21 26 +5
Lines 900 935 +35
Branches 206 208 +2
==========================================
+ Hits 824 828 +4
- Misses 71 101 +30
- Partials 5 6 +1 ☔ View full report in Codecov by Sentry. |
Member
|
Fixed with #726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stackblitz reproduction.
Notice how the "Submit" button is not disabled, but the
onMountvalidator returned an error (as shown next to the field).I would expect
canSubmitto returnfalsewhen anonMounterror is present instead oftruelike it does right now until the field is touched.It seems wrong it's possible for the user to press submit without the form being in a valid state.