Skip to content

test: verify zod validator returns ValidationError[] - #943

Closed
Pascalmh wants to merge 1 commit into
TanStack:mainfrom
Pascalmh:zod-form-adapter-errors
Closed

test: verify zod validator returns ValidationError[]#943
Pascalmh wants to merge 1 commit into
TanStack:mainfrom
Pascalmh:zod-form-adapter-errors

Conversation

@Pascalmh

@Pascalmh Pascalmh commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

For now this is just a failing test

ToDo:

  • implement the fix
  • optional?: refactor the test - add a new test instead of extending the existing one

refs #942

@nx-cloud

nx-cloud Bot commented Sep 6, 2024

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cc17fa2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pkg-pr-new

pkg-pr-new Bot commented Sep 6, 2024

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@943

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@943

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@943

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@943

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@943

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@943

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@943

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@943

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@943

commit: cc17fa2

@Pascalmh
Pascalmh force-pushed the zod-form-adapter-errors branch from b4d57fa to ff9f67e Compare September 9, 2024 13:15
refs TanStack#942

Signed-off-by: Pascal Küsgen <pascalkuesgen@gmail.com>
@Pascalmh

Copy link
Copy Markdown
Contributor Author

As the ZodAdapter is deprecated and will be removed I moved the test to go against the Standard Validator, see #1077

@Pascalmh Pascalmh closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant