Skip to content

fix: improve long running task performance in query core - #8107

Merged
TkDodo merged 12 commits into
TanStack:mainfrom
Aghassi:query/core-performance-improvment
Oct 9, 2024
Merged

fix: improve long running task performance in query core#8107
TkDodo merged 12 commits into
TanStack:mainfrom
Aghassi:query/core-performance-improvment

Conversation

@Aghassi

@Aghassi Aghassi commented Sep 28, 2024

Copy link
Copy Markdown
Contributor

This addresses two hot spots we have noticed
on a large scale enterprise app when profiling
with chrome. These changes help to cut down
on long running tasks when there are many query
calls on the page

davidaghassi
fix: improve long running task performance in query core
3394b38 
This addresses two hot spots we have noticed
on a large scale enterprise app when profiling
with chrome. These changes help to cut down
on long running tasks when there are many query
calls on the page
@Aghassi

Aghassi commented Sep 28, 2024

Copy link
Copy Markdown
Contributor Author

This uses parts of #8092 as well

@Aghassi
Aghassi marked this pull request as ready for review September 28, 2024 22:00
@Aghassi

Aghassi commented Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

@tannerlinsley Would you be open to taking this fix? Anything I can provide additionally to help with making it easier to take in? Would love to give this one to the community and not maintain an internal patch if I can.

@TkDodo

TkDodo commented Oct 3, 2024

Copy link
Copy Markdown
Collaborator

This uses parts of #8092 as well

yeah let’s not mix PRs / improvements please. I have reviewed the Proxy one already and left a comment. I’m also fine with this change in isolation.

@nx-cloud

nx-cloud Bot commented Oct 3, 2024 •
edited
Loading

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2d2239d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new

pkg-pr-new Bot commented Oct 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8107

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8107

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8107

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8107

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8107

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8107

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8107

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8107

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8107

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8107

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8107

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8107

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8107

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8107

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8107

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8107

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8107

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8107

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8107

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8107

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8107

commit: a628365

@codecov

codecov Bot commented Oct 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.08%. Comparing base (2fe16e5) to head (2d2239d).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8107       +/-   ##
===========================================
+ Coverage   45.41%   62.08%   +16.67%     
===========================================
  Files         200      136       -64     
  Lines        7456     4758     -2698     
  Branches     1696     1335      -361     
===========================================
- Hits         3386     2954      -432     
+ Misses       3694     1564     -2130     
+ Partials      376      240      -136
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 93.12% <95.83%> (+0.11%) ⬆️
@tanstack/query-devtools 4.79% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 93.12% <100.00%> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.51% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@Aghassi

Aghassi commented Oct 3, 2024

Copy link
Copy Markdown
Contributor Author

This uses parts of #8092 as well

yeah let’s not mix PRs / improvements please. I have reviewed the Proxy one already and left a comment. I’m also fine with this change in isolation.

Sounds good, I will drop the other diff from this and focus just on the one file

@Aghassi

Aghassi commented Oct 3, 2024

Copy link
Copy Markdown
Contributor Author

@TkDodo Updated to just address the one performance issue

@TkDodo
TkDodo merged commit 5499577 into TanStack:main Oct 9, 2024
This was referenced Oct 31, 2024
Closed
Closed
Merged
@muhiddinjv muhiddinjv mentioned this pull request Oct 31, 2024
Closed
@Bancha-t Bancha-t mentioned this pull request Oct 31, 2024
Open
@Bonniemarie216 Bonniemarie216 mentioned this pull request Oct 31, 2024
Open
This was referenced Nov 2, 2024
Closed
Closed
@jwinr jwinr mentioned this pull request Nov 4, 2024
Merged
@CalPinSW CalPinSW mentioned this pull request Nov 5, 2024
Merged
@GouravNG GouravNG mentioned this pull request Nov 5, 2024
Open
This was referenced Nov 7, 2024
Closed
Closed
@muhiddinjv muhiddinjv mentioned this pull request Nov 7, 2024
Closed
@doperiddle doperiddle mentioned this pull request Nov 8, 2024
Merged
@snyk-io snyk-io Bot mentioned this pull request Nov 9, 2024
Closed
@muhammadahsanmirza muhammadahsanmirza mentioned this pull request Nov 10, 2024
Open
@JulianFl JulianFl mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees

No one assigned

Labels

package: query-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aghassi @TkDodo