fix(react-query): resolve overload matches error with exactOptionalPropertyTypes in query options by gwansikk · Pull Request #8186 · TanStack/query

gwansikk · 2024-10-15T16:53:11Z

Resolve overload matches error in queryOptions, infiniteQueryOptions when exactOptionalPropertyTypes in typescript is enabled.

…opertyTypes in queryOptions

nx-cloud · 2024-10-15T16:53:41Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f04b36a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

pkg-pr-new · 2024-10-15T16:55:06Z

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8186

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8186

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8186

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8186

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8186

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8186

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8186

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8186

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8186

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8186

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8186

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8186

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8186

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8186

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8186

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8186

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8186

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8186

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8186

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8186

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8186

commit: f04b36a

codecov · 2024-10-15T16:57:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (2fe16e5) to head (f04b36a).
Report is 36 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8186       +/-   ##
===========================================
+ Coverage   45.41%   81.84%   +36.43%     
===========================================
  Files         200       26      -174     
  Lines        7456      358     -7098     
  Branches     1696       98     -1598     
===========================================
- Hits         3386      293     -3093     
+ Misses       3694       56     -3638     
+ Partials      376        9      -367

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/react-query	`93.10% <100.00%> (-0.03%)`	⬇️
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

magneticmeganlovesjhonny

Reviewed

fix(react-query): resolve overload matches error with exactOptionalPr…

f04b36a

…opertyTypes in queryOptions

github-actions Bot added the package: react-query label Oct 15, 2024

gwansikk marked this pull request as ready for review October 15, 2024 17:06

TkDodo merged commit 6c06781 into TanStack:main Oct 15, 2024

gwansikk deleted the fix/exact-optional-property-types branch October 15, 2024 17:18

magneticmeganlovesjhonny reviewed Oct 20, 2024

View reviewed changes

liam-russell mentioned this pull request Nov 6, 2024

[Snyk] Upgrade @tanstack/react-query from 5.59.13 to 5.59.15 liam-russell/liamr.co#2

Closed

This was referenced Nov 7, 2024

[Snyk] Upgrade @tanstack/react-query-persist-client from 5.56.1 to 5.59.15 zntb/crypto-ticker#69

Closed

[Snyk] Upgrade @tanstack/react-query from 5.59.8 to 5.59.15 zntb/crypto-ticker#71

Merged

muhiddinjv mentioned this pull request Nov 7, 2024

[Snyk] Upgrade @tanstack/react-query from 5.45.1 to 5.59.15 muhiddinjv/ollio-app#117

Closed

doperiddle mentioned this pull request Nov 8, 2024

[Snyk] Upgrade @tanstack/react-query from 5.18.1 to 5.59.15 doperiddle/web-examples#10

Merged

snyk-io Bot mentioned this pull request Nov 9, 2024

[Snyk] Upgrade @tanstack/react-query from 4.19.1 to 5.59.15 doperiddle/chainlist#6

Closed

muhammadahsanmirza mentioned this pull request Nov 10, 2024

[Snyk] Upgrade @tanstack/react-query from 5.54.1 to 5.59.15 muhammadahsanmirza/internship-portal-client-view#7

Open

JulianFl mentioned this pull request Nov 10, 2024

[Snyk] Upgrade @tanstack/react-query from 5.32.1 to 5.59.15 JulianFl/PicturaObscura#21

Open

This was referenced Feb 27, 2026

[expo-router] Support exactOptionalPropertyTypes expo/expo#43506

Closed

expo-router types incompatible with exactOptionalPropertyTypes (even with skipLibCheck: true) expo/expo#43508

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(react-query): resolve overload matches error with exactOptionalPropertyTypes in query options - #8186

fix(react-query): resolve overload matches error with exactOptionalPropertyTypes in query options#8186
TkDodo merged 1 commit into
TanStack:mainfrom
gwansikk:fix/exact-optional-property-types

gwansikk commented Oct 15, 2024

Uh oh!

nx-cloud Bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 15, 2024

Uh oh!

codecov Bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

magneticmeganlovesjhonny left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

gwansikk commented Oct 15, 2024

Uh oh!

nx-cloud Bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

pkg-pr-new Bot commented Oct 15, 2024

Uh oh!

codecov Bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

magneticmeganlovesjhonny left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nx-cloud Bot commented Oct 15, 2024 •

edited

Loading

codecov Bot commented Oct 15, 2024 •

edited

Loading