Angular persist query client experimental by OmerGronich · Pull Request #8324 · TanStack/query

OmerGronich · 2024-11-22T14:57:03Z

Angular Query Persister Plugin

Created angular-query-persist-client-package
Implemented withPersistQueryClient in new package
Added isRestoring provider and injection token to main angular-query package

nx-cloud · 2024-11-22T15:41:01Z

View your CI Pipeline Execution ↗ for commit 14509a2.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 21s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2m 8s	View ↗

☁️ Nx Cloud last updated this comment at 2025-04-13 15:32:04 UTC

arnoud-dv

Some suggestions for now, I still need to do a more in-depth review of the persistence itself.

- Created isRestoring injection token and provider - handled restoration phase in create-base-query.ts - handled restoration phase in

…port, and the withPersistQueryClient feature

…r migration

crutchcorn

I was requested to review this PR from OP - it generally looks good to me! Seems like a lot of edgecases handled as well.

Anything you want to me to take a closer eye on?

…ry-client-experimental

…ector)

…ray structure for persistOptions

…kage name and updated configurations

…ry-client-experimental

pkg-pr-new · 2025-04-13T15:10:51Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8324

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8324

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8324

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8324

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8324

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8324

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8324

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8324

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8324

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8324

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8324

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8324

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8324

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8324

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8324

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8324

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8324

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8324

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8324

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8324

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8324

commit: 14509a2

codecov · 2025-04-13T15:13:38Z

Codecov Report

Attention: Patch coverage is 75.43860% with 14 lines in your changes missing coverage. Please review.

Project coverage is 44.44%. Comparing base (3471d0f) to head (14509a2).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8324      +/-   ##
==========================================
+ Coverage   44.32%   44.44%   +0.12%     
==========================================
  Files         202      204       +2     
  Lines        8063     8099      +36     
  Branches     1784     1796      +12     
==========================================
+ Hits         3574     3600      +26     
- Misses       4059     4067       +8     
- Partials      430      432       +2

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`85.32% <62.16%> (-2.77%)`	⬇️
@tanstack/eslint-plugin-query	`83.02% <ø> (ø)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`95.47% <ø> (ø)`
@tanstack/query-devtools	`3.61% <ø> (ø)`
@tanstack/query-persist-client-core	`73.46% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/react-query	`95.42% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.48% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.15% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.01% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions Bot added the package: angular-query-experimental label Nov 22, 2024

OmerGronich marked this pull request as draft November 22, 2024 14:58

OmerGronich force-pushed the angular-persist-query-client-experimental branch from 8474149 to 31c8c0e Compare November 22, 2024 15:01

OmerGronich force-pushed the angular-persist-query-client-experimental branch 3 times, most recently from 0ff5f5c to b4d880a Compare November 23, 2024 12:00

OmerGronich closed this Nov 23, 2024

OmerGronich deleted the angular-persist-query-client-experimental branch November 23, 2024 12:00

OmerGronich restored the angular-persist-query-client-experimental branch November 23, 2024 12:00

OmerGronich reopened this Nov 23, 2024

OmerGronich force-pushed the angular-persist-query-client-experimental branch from 566f72a to e1ae58d Compare November 23, 2024 19:42

OmerGronich marked this pull request as ready for review November 23, 2024 20:12

arnoud-dv self-assigned this Nov 26, 2024

OmerGronich force-pushed the angular-persist-query-client-experimental branch 2 times, most recently from d4fa95c to 9e4182a Compare November 29, 2024 13:27

arnoud-dv requested changes Dec 1, 2024

View reviewed changes

OmerGronich force-pushed the angular-persist-query-client-experimental branch 3 times, most recently from 3c3c8ec to ed0ed3c Compare December 7, 2024 14:40

OmerGronich added 10 commits December 7, 2024 22:44

feat(angular-query):

f327a5d

- Created isRestoring injection token and provider - handled restoration phase in create-base-query.ts - handled restoration phase in

feat(angular-query): created package for experimental persistence sup…

dd92bfc

…port, and the withPersistQueryClient feature

test(persistQuery): add tests for withPersistQueryClient

b8afd8a

docs(angular-query): add basic persister example

547ae9e

fix(angular-query): synced angular versions in new package

7130913

fix(angular-query): commit before ng update

5709184

feat(angular-query): updated example to v18

9e6ef24

fix(angular-query): fixed project name to basic-persister

962cf32

feat(angular-query): updated example basic-persister to v19

4d305a5

feat(angular-query): included back the persister package after angula…

630e462

…r migration

crutchcorn reviewed Mar 10, 2025

View reviewed changes

OmerGronich commented Mar 12, 2025

View reviewed changes

Comment thread packages/angular-query-experimental/src/create-base-query.ts

arnoud-dv added 7 commits April 10, 2025 20:32

Merge remote-tracking branch 'upstream/main' into angular-persist-que…

08b903c

…ry-client-experimental

update build configs

1df9802

Merge branch 'main' into angular-persist-query-client-experimental

112d35b

zoneless unit tests

e8eb3cf

replace deprecated injectQueryClient

4e042b7

createBaseQuery is always run in injection context, remove inject(Inj…

43f3500

…ector)

remove api extractor config

3393d0c

arnoud-dv reviewed Apr 10, 2025

View reviewed changes

Comment thread packages/angular-persist-query-client-experimental/src/with-persist-query-client.ts Outdated

Comment thread packages/angular-persist-query-client-experimental/src/with-persist-query-client.ts Outdated

arnoud-dv and others added 4 commits April 11, 2025 00:00

update example dependencies

ddf477f

comment out from publish script for now

9ac5fd3

Merge branch 'main' into angular-persist-query-client-experimental

102a951

refactor(persist-query-client): simplify configuration by removing ar…

28cce6c

…ray structure for persistOptions

OmerGronich requested review from arnoud-dv and crutchcorn April 11, 2025 18:28

refactor(angular-query-persist-client): removed experimental from pac…

2afedee

…kage name and updated configurations

arnoud-dv force-pushed the angular-persist-query-client-experimental branch from 4f52f3a to 3c7a516 Compare April 13, 2025 12:46

fix example

12e9b00

arnoud-dv force-pushed the angular-persist-query-client-experimental branch from 3c7a516 to 12e9b00 Compare April 13, 2025 12:47

arnoud-dv added 3 commits April 13, 2025 15:28

Merge remote-tracking branch 'upstream/main' into angular-persist-que…

957670c

…ry-client-experimental

fix outdated comment

0e30dd9

exclude from preview for now

118cd24

mark package as private instead

14509a2

arnoud-dv approved these changes Apr 13, 2025

View reviewed changes

arnoud-dv removed their assignment Apr 13, 2025

configure injectIsRestoring injector through options object

254a978

arnoud-dv merged commit 967c231 into TanStack:main Apr 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Angular persist query client experimental - #8324

Angular persist query client experimental#8324
arnoud-dv merged 57 commits into
TanStack:mainfrom
OmerGronich:angular-persist-query-client-experimental

OmerGronich commented Nov 22, 2024 •

edited

Loading

Uh oh!

nx-cloud Bot commented Nov 22, 2024 •

edited

Loading

Uh oh!

arnoud-dv left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crutchcorn left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented Apr 13, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Apr 13, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

OmerGronich commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Angular Query Persister Plugin

Uh oh!

nx-cloud Bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arnoud-dv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crutchcorn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OmerGronich commented Nov 22, 2024 •

edited

Loading

nx-cloud Bot commented Nov 22, 2024 •

edited

Loading

pkg-pr-new Bot commented Apr 13, 2025 •

edited

Loading

codecov Bot commented Apr 13, 2025 •

edited

Loading