fix(start): align Rsbuild SSR asset URLs for css?url imports - #7590
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRsbuild planning now builds client, server, and provider asset paths through shared helpers. The e2e app adds a ChangesRsbuild asset URL alignment
E2E example page styling
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you very much for such a quick fix! |
|
View your CI Pipeline Execution ↗ for commit f628608
☁️ Nx Cloud last updated this comment at |
Merging this PR will degrade performance by 9.11%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server serialization-payload (vue) |
3.5 MB | 6.1 MB | -42.86% |
| ❌ | Simulation | ssr global-mw document (vue) |
211 ms | 221.1 ms | -4.59% |
| ❌ | Memory | mem server error-paths not-found (react) |
266.1 KB | 277.4 KB | -4.07% |
| ❌ | Memory | mem server error-paths redirect (vue) |
295.9 KB | 305.4 KB | -3.14% |
| ⚡ | Memory | mem client preload-churn (vue) |
712.4 KB | 668.5 KB | +6.57% |
| ⚡ | Memory | mem server server-fn-churn (vue) |
274.7 KB | 263.1 KB | +4.4% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing SyMind:fix-rsbuild-inline-css (f628608) with main (77ed6d5)1
Footnotes
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We investigated the tanstack-vue-start-e2e-basic:test:e2e--vite-prerender failure and determined it is unrelated to this PR's changes. The error references a missing isPrerender export in a Vue e2e utility module that our diff does not touch, and the project itself is not among the affected projects. We are classifying this as an environment state issue — likely a stale build artifact — rather than a regression introduced by this PR.
No code changes were suggested for this issue.
You can trigger a rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🎓 Learn more about Self-Healing CI on nx.dev
Fix #7543
css?urlimports resolve to client-served asset URLs.rsc-rsbuilde2e route that imports a stylesheet with?urland verifies the actual element style is applied.rsc-rsbuildfixture homepage and node_modules client component page to match the main RSC fixture’s server/client visual style.Summary by CodeRabbit
?urlimports so server-rendered pages load the same public assets as the client.?url(including injection into the document head).?urlstyles.*.css?urlimports.