fix(router-core): harden lane loading lifecycle - #7869
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 887ab0a
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will regress 14 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server error-paths not-found (solid) |
413.5 KB | 770.9 KB | -46.36% |
| ❌ | Memory | mem client preload-churn (react) |
436.4 KB | 803.6 KB | -45.7% |
| ❌ | Memory | mem client unique-location-churn (solid) |
419.9 KB | 687 KB | -38.87% |
| ❌ | Memory | mem server error-paths not-found (vue) |
330.8 KB | 501.8 KB | -34.07% |
| ❌ | Memory | mem client loader-data-retention (vue) |
779 KB | 979.8 KB | -20.49% |
| ❌ | Memory | mem server peak-large-page (vue) |
728.6 KB | 817.4 KB | -10.86% |
| ❌ | Memory | mem server error-paths not-found (react) |
251.3 KB | 277 KB | -9.26% |
| ❌ | Simulation | ssr request loop (solid) |
146.2 ms | 155.3 ms | -5.83% |
| ❌ | Simulation | client-control-flow navigation loop (vue) |
54 ms | 56.9 ms | -5.05% |
| ❌ | Simulation | ssr control-flow unmatched 404 (react) |
56.9 ms | 59.5 ms | -4.26% |
| ❌ | Simulation | client-loaders navigation loop (solid) |
79.2 ms | 82.6 ms | -4.16% |
| ❌ | Memory | mem server server-fn-churn (react) |
273.8 KB | 283.8 KB | -3.53% |
| ❌ | Memory | mem server error-paths unmatched (solid) |
412.4 KB | 425.6 KB | -3.11% |
| ❌ | Memory | mem server error-paths redirect (solid) |
290.4 KB | 299.7 KB | -3.09% |
| ⚡ | Memory | mem server server-fn-churn (vue) |
3,969.9 KB | 263.5 KB | ×15 |
| ⚡ | Memory | mem server serialization-payload (solid) |
6.8 MB | 3.4 MB | +96.61% |
| ⚡ | Memory | mem client unique-location-churn (vue) |
1,229.7 KB | 1,001.4 KB | +22.8% |
| ⚡ | Memory | mem server error-paths redirect (vue) |
371.7 KB | 303.2 KB | +22.59% |
| ⚡ | Memory | mem server request-churn (solid) |
481.3 KB | 419.4 KB | +14.77% |
| ⚡ | Memory | mem client navigation-churn (solid) |
673 KB | 587 KB | +14.65% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix-router-core-lane-match-loader-followups (887ab0a) with fix-router-core-lane-match-loader (7443d96)
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We investigated both e2e failures and found neither is caused by this PR's changes. The collectBrowserErrors error stems from stale build artifacts in e2e-utils/dist — a package untouched by this PR — and the port 46007 conflict is a pre-existing environment resource issue. Our recommendation is to re-run the pipeline after clearing build caches and ensuring no orphaned processes are holding the port.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
1f27102
into
fix-router-core-lane-match-loader
Summary
Testing
@tanstack/router-core:test:unitsuite: 1470 passed, 3 expected failuresgit diff --checkBundle size
Final deltas against this PR base range from +267 to +360 gzip bytes across the 17 scenarios. The optimization pass recovered 48 to 76 gzip bytes per scenario from the initial correctness fix set.