perf(router): reduce SSR lane loading overhead - #7875
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit afcb006
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will regress 5 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server error-paths not-found (solid) |
707 KB | 930.5 KB | -24.02% |
| ❌ | Memory | mem server serialization-payload (vue) |
3.4 MB | 3.7 MB | -8.35% |
| ❌ | Memory | mem client navigation-churn (solid) |
525.2 KB | 549.3 KB | -4.39% |
| ❌ | Simulation | ssr request loop (solid) |
158 ms | 164 ms | -3.65% |
| ❌ | Memory | mem server server-fn-churn (react) |
274.2 KB | 283.4 KB | -3.26% |
| ⚡ | Memory | mem server peak-large-page (react) |
2,033.2 KB | 944.5 KB | ×2.2 |
| ⚡ | Memory | mem server error-paths redirect (vue) |
460 KB | 293.3 KB | +56.82% |
| ⚡ | Memory | mem server aborted-requests (react) |
746.5 KB | 560.4 KB | +33.22% |
| ⚡ | Memory | mem client unique-location-churn (solid) |
401.4 KB | 342.4 KB | +17.24% |
| ⚡ | Memory | mem server error-paths not-found (react) |
276.9 KB | 254.9 KB | +8.63% |
| ⚡ | Simulation | ssr dehydrate plain control (react) |
53.9 ms | 49.9 ms | +8.15% |
| ⚡ | Simulation | ssr dehydrate plain control (solid) |
72.9 ms | 68.6 ms | +6.26% |
| ⚡ | Simulation | ssr before-load chain (react) |
53.3 ms | 50.3 ms | +6.14% |
| ⚡ | Simulation | ssr server-fn during document ssr (react) |
67.7 ms | 64 ms | +5.72% |
| ⚡ | Memory | mem server server-fn-churn (vue) |
274.5 KB | 263.7 KB | +4.1% |
| ⚡ | Simulation | ssr global-mw server-fn (solid) |
59.8 ms | 57.6 ms | +3.75% |
| ⚡ | Simulation | ssr assets inline-css cdn (solid) |
62 ms | 60.1 ms | +3.2% |
| ⚡ | Simulation | ssr assets inline-css cdn (react) |
52.9 ms | 51.3 ms | +3.19% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix-router-ssr-loader-performance (389e717) with fix-router-core-lane-match-loader (1f27102)
03a1fde
into
fix-router-core-lane-match-loader
Summary
Performance
Validation