chore(router-core): lane match loader final byte-shave - #7885
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 2c15061
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview4 package(s) bumped directly, 19 bumped as dependents. 🟩 Patch bumps
|
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will degrade performance by 13.66%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server server-fn-churn (vue) |
274.1 KB | 4,294.9 KB | -93.62% |
| ❌ | Memory | mem server error-paths unmatched (react) |
272.5 KB | 717.8 KB | -62.04% |
| ❌ | Memory | mem server error-paths not-found (solid) |
411.1 KB | 771.8 KB | -46.74% |
| ❌ | Memory | mem client unique-location-churn (solid) |
341 KB | 539.1 KB | -36.75% |
| ❌ | Simulation | ssr server-fn not-found (solid) |
61.7 ms | 70.2 ms | -12.01% |
| ❌ | Simulation | ssr server-fn POST (solid) |
64.8 ms | 71.5 ms | -9.48% |
| ❌ | Simulation | ssr server-fn send-context (solid) |
65.9 ms | 71.5 ms | -7.85% |
| ❌ | Simulation | ssr server-fn redirect (solid) |
52.4 ms | 56.3 ms | -6.95% |
| ❌ | Simulation | ssr server-fn GET (solid) |
70.6 ms | 75.2 ms | -6.15% |
| ❌ | Memory | mem server error-paths redirect (react) |
184.8 KB | 195.5 KB | -5.49% |
| ❌ | Simulation | ssr selective (solid) |
70.3 ms | 73.8 ms | -4.67% |
| ❌ | Memory | mem server error-paths not-found (vue) |
331.1 KB | 346.9 KB | -4.56% |
| ❌ | Simulation | ssr control-flow route headers (react) |
59.9 ms | 62.5 ms | -4.11% |
| ❌ | Memory | mem server error-paths not-found (react) |
256.1 KB | 265.8 KB | -3.65% |
| ⚡ | Memory | mem server error-paths unmatched (solid) |
3,059.5 KB | 423.8 KB | ×7.2 |
| ⚡ | Memory | mem server error-paths redirect (vue) |
569.7 KB | 323.6 KB | +76.02% |
| ⚡ | Memory | mem server error-paths redirect (solid) |
309.6 KB | 287 KB | +7.88% |
| ⚡ | Memory | mem client navigation-churn (vue) |
1.3 MB | 1.2 MB | +4.41% |
| ⚡ | Simulation | client-rewrites navigation loop (solid) |
84.5 ms | 81.8 ms | +3.28% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix-router-core-lane-match-loader-byte-shaving (2c15061) with fix-router-core-lane-match-loader (baa18cd)
55ceb3a
into
fix-router-core-lane-match-loader
No description provided.