Use scoped Vitest cleanup in lane regression tests - #7923
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit afaa22d
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview4 package(s) bumped directly, 19 bumped as dependents. 🟩 Patch bumps
|
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will regress 12 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server peak-large-page (react) |
959.7 KB | 2,055.5 KB | -53.31% |
| ❌ | Memory | mem client unique-location-churn (react) |
665.1 KB | 764.6 KB | -13.02% |
| ❌ | Simulation | ssr request loop (solid) |
151 ms | 164.6 ms | -8.25% |
| ❌ | Simulation | ssr server-fn not-found (solid) |
61.7 ms | 66.8 ms | -7.62% |
| ❌ | Simulation | ssr server-fn POST (solid) |
64.8 ms | 69.4 ms | -6.74% |
| ❌ | Memory | mem server error-paths error (solid) |
912.6 KB | 965.3 KB | -5.45% |
| ❌ | Simulation | ssr server-fn send-context (solid) |
65.9 ms | 69.7 ms | -5.35% |
| ❌ | Simulation | ssr server-fn GET (solid) |
70.7 ms | 74.4 ms | -4.94% |
| ❌ | Memory | mem server server-fn-churn (vue) |
263.6 KB | 274.4 KB | -3.94% |
| ❌ | Simulation | ssr selective (solid) |
70.2 ms | 73 ms | -3.75% |
| ❌ | Simulation | ssr server-fn multipart (solid) |
62.2 ms | 64.2 ms | -3.1% |
| ❌ | Simulation | ssr server-fn raw-stream (solid) |
108.4 ms | 111.7 ms | -3.03% |
| ⚡ | Memory | mem server error-paths not-found (vue) |
2,368.1 KB | 341.7 KB | ×6.9 |
| ⚡ | Memory | mem server error-paths unmatched (react) |
604.3 KB | 271.3 KB | ×2.2 |
| ⚡ | Memory | mem client unique-location-churn (solid) |
542.4 KB | 465 KB | +16.65% |
| ⚡ | Memory | mem server error-paths redirect (solid) |
283.2 KB | 272.9 KB | +3.76% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/scoped-vitest-cleanup (afaa22d) with fix-router-core-lane-match-loader (1d20a9d)
b8204ea
into
fix-router-core-lane-match-loader
Summary
try/finallycleanup wrappers in tests added or modified byfix-router-core-lane-match-loaderwith test-localonTestFinishedcallbackstry/finallyblocks wherefinallymust run before later assertions or is itself behavior under testWhy
The broad wrappers add substantial nesting around each test's assertion path. Test-local cleanup keeps teardown scoped to the individual test and still runs when the test fails, while making the behavior being asserted easier to read.
Validation
test:typesfor all six affected packagestest:eslintfor all six affected packagesgit diff --check