Skip to content

fix(eslint-plugin-start): support ESLint 10 peer dependency - #7924

Merged
schiller-manuel merged 1 commit into
TanStack:mainfrom
bhaveshdesale:fix/eslint10-peer-dependency
Jul 30, 2026
Merged

fix(eslint-plugin-start): support ESLint 10 peer dependency#7924
schiller-manuel merged 1 commit into
TanStack:mainfrom
bhaveshdesale:fix/eslint10-peer-dependency

Conversation

@bhaveshdesale

@bhaveshdesale bhaveshdesale commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates the peer dependency for @tanstack/eslint-plugin-start to include ESLint 10, bringing it in line with @tanstack/eslint-plugin-router.

Changes

  • Added ^10.0.0 to the eslint peer dependency range.

Testing

I attempted to run the package tests on Windows, but the repository installation fails during the e2e/solid-start/basic-cloudflare postinstall step due to the WRANGLER_LOG=warn environment variable syntax not being recognized on Windows. This appears to be unrelated to this metadata-only change.

Related

Closes #7920

Summary by CodeRabbit

  • Chores
    • Added compatibility for ESLint 10.
    • Continued support for existing ESLint 8 and 9 versions.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 38b1fb37-536f-487f-8b72-0d3720735eec

📥 Commits

Reviewing files that changed from the base of the PR and between a3ee355 and a393f6d.

📒 Files selected for processing (1)
  • packages/eslint-plugin-start/package.json

📝 Walkthrough

Walkthrough

The Start ESLint plugin package metadata expands its ESLint peer dependency compatibility range from versions 8 and 9 to versions 8, 9, and 10.

Changes

ESLint peer compatibility

Layer / File(s) Summary
Update ESLint peer range
packages/eslint-plugin-start/package.json
The eslint peer dependency now includes ^10.0.0 alongside the existing ^8.57.0 and ^9.0.0 ranges.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: schiller-manuel

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding ESLint 10 peer dependency support for the Start plugin.
Linked Issues check ✅ Passed The package.json change matches issue #7920 by extending @tanstack/eslint-plugin-start to accept ESLint 10.
Out of Scope Changes check ✅ Passed The PR is narrowly scoped to the requested peer dependency update with no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit a393f6d

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 5m 33s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 17s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-30 20:11:58 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jul 30, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7924

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7924

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7924

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7924

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7924

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7924

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7924

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7924

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7924

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7924

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7924

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7924

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7924

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7924

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7924

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7924

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7924

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7924

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7924

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7924

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7924

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7924

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7924

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7924

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7924

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7924

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7924

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7924

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7924

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7924

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7924

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7924

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7924

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7924

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7924

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7924

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7924

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7924

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7924

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7924

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7924

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7924

commit: a393f6d

@codspeed-hq

codspeed-hq Bot commented Jul 30, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 7.01%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 3 regressed benchmarks
✅ 173 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory mem server peak-large-page (react) 943.7 KB 2,082.8 KB -54.69%
Memory mem server server-fn-churn (solid) 263.3 KB 274.1 KB -3.96%
Simulation ssr dehydrate rich types (solid) 73 ms 75.3 ms -3.08%
Memory mem server error-paths redirect (vue) 676.3 KB 528.7 KB +27.91%
Memory mem server server-fn-churn (react) 281.8 KB 271.4 KB +3.81%
Memory mem server error-paths not-found (react) 276.8 KB 266.8 KB +3.74%
Memory mem server error-paths unmatched (react) 273.9 KB 264.7 KB +3.47%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing bhaveshdesale:fix/eslint10-peer-dependency (a393f6d) with main (a3ee355)

Open in CodSpeed

@schiller-manuel
schiller-manuel merged commit 77ed6d5 into TanStack:main Jul 30, 2026
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@tanstack/eslint-plugin-start doesn't have the same eslint peer dependency as the other plugins

2 participants