fix(eslint-plugin-start): support ESLint 10 peer dependency - #7924
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Start ESLint plugin package metadata expands its ESLint peer dependency compatibility range from versions 8 and 9 to versions 8, 9, and 10. ChangesESLint peer compatibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit a393f6d
☁️ Nx Cloud last updated this comment at |
Merging this PR will degrade performance by 7.01%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server peak-large-page (react) |
943.7 KB | 2,082.8 KB | -54.69% |
| ❌ | Memory | mem server server-fn-churn (solid) |
263.3 KB | 274.1 KB | -3.96% |
| ❌ | Simulation | ssr dehydrate rich types (solid) |
73 ms | 75.3 ms | -3.08% |
| ⚡ | Memory | mem server error-paths redirect (vue) |
676.3 KB | 528.7 KB | +27.91% |
| ⚡ | Memory | mem server server-fn-churn (react) |
281.8 KB | 271.4 KB | +3.81% |
| ⚡ | Memory | mem server error-paths not-found (react) |
276.8 KB | 266.8 KB | +3.74% |
| ⚡ | Memory | mem server error-paths unmatched (react) |
273.9 KB | 264.7 KB | +3.47% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing bhaveshdesale:fix/eslint10-peer-dependency (a393f6d) with main (a3ee355)
Summary
Updates the peer dependency for
@tanstack/eslint-plugin-startto include ESLint 10, bringing it in line with@tanstack/eslint-plugin-router.Changes
^10.0.0to theeslintpeer dependency range.Testing
I attempted to run the package tests on Windows, but the repository installation fails during the
e2e/solid-start/basic-cloudflarepostinstall step due to theWRANGLER_LOG=warnenvironment variable syntax not being recognized on Windows. This appears to be unrelated to this metadata-only change.Related
Closes #7920
Summary by CodeRabbit