Upgrade solidjs beta 29 + solid-query beta 7 - #7928
Conversation
Upgrade `solid-js`, `@solidjs/web` and `babel-preset-solid` to `2.0.0-beta.29`, and `vite-plugin-solid` to `3.0.0-next.20` (peer-requires `>=2.0.0-beta.28`). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d8961ad
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview6 package(s) bumped directly, 0 bumped as dependents. 🟩 Patch bumps
|
Bundle Size Benchmarks
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Peer-requires `>=2.0.0-beta.29` (already satisfied) and ships `@dom-expressions/compiler@0.50.0-next.34`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merging this PR will improve performance by 57.94%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | ssr request loop (react) |
330.5 ms | 77.9 ms | ×4.2 |
| ⚡ | Simulation | client-side navigation loop (solid) |
72.6 ms | 43.2 ms | +68.31% |
| ⚡ | Simulation | ssr request loop (vue) |
420.3 ms | 284.5 ms | +47.73% |
| ⚡ | Simulation | ssr request loop (solid) |
174.6 ms | 142.6 ms | +22.46% |
| ⚡ | Simulation | client-side navigation loop (react) |
56.3 ms | 50.3 ms | +11.76% |
| ⚡ | Simulation | client-side navigation loop (vue) |
83 ms | 77.2 ms | +7.56% |
| 🆕 | Simulation | ssr not-found (vue) |
N/A | 169.7 ms | N/A |
| 🆕 | Simulation | ssr redirect (vue) |
N/A | 68.2 ms | N/A |
| 🆕 | Simulation | ssr head (vue) |
N/A | 327.4 ms | N/A |
| 🆕 | Simulation | ssr loaders (vue) |
N/A | 136.9 ms | N/A |
| 🆕 | Simulation | ssr selective (vue) |
N/A | 139.7 ms | N/A |
| 🆕 | Simulation | ssr server-fn GET (vue) |
N/A | 74.4 ms | N/A |
| 🆕 | Simulation | ssr server-fn POST (vue) |
N/A | 71.4 ms | N/A |
| 🆕 | Simulation | ssr server-route middleware (vue) |
N/A | 63.3 ms | N/A |
| 🆕 | Simulation | ssr server-route (vue) |
N/A | 60.8 ms | N/A |
| 🆕 | Simulation | ssr streaming deferred (vue) |
N/A | 105 ms | N/A |
| 🆕 | Simulation | ssr assets inline-css cdn (vue) |
N/A | 188.4 ms | N/A |
| 🆕 | Simulation | ssr assets linked-css control (vue) |
N/A | 216 ms | N/A |
| 🆕 | Simulation | ssr before-load chain (vue) |
N/A | 184.4 ms | N/A |
| 🆕 | Simulation | ssr control-flow error 500 (vue) |
N/A | 197.7 ms | N/A |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing upgrade-solidjs-beta-29 (d8961ad) with solid-router-v2-pre (67a9040)1
Footnotes
Bump `@tanstack/solid-query` and `@tanstack/solid-query-devtools` to `6.0.0-beta.7`. The devtools package peer-requires `@tanstack/solid-query: ^6.0.0-beta.7`, so the two must move together. `@tanstack/solid-query` is pinned through the `catalog:` entry in pnpm-workspace.yaml and forced repo-wide via `overrides`, so the catalog value is bumped alongside the package.json ranges — editing the package.json ranges alone has no effect on resolution. Both packages are added to `minimumReleaseAgeExclude`; the repo gates on `minimumReleaseAge: 1440` and these betas are newer than that. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We investigated the tanstack-react-start-e2e-rsc:test:e2e--vite-ssr--shard-3-of-6 failure and determined it is unrelated to this PR, which exclusively upgrades Solid.js packages. The SyntaxError: Unexpected end of input occurred in a React project after a successful HTTP 200 response, consistent with a corrupted build artifact in the CI environment rather than any code change introduced here. We recommend re-running the pipeline to resolve this transient environment issue.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
Upgrades to the latest Solid 2.0 beta (skips over beta.28), the latest plugin, and the latest Solid Query beta.
solid-js,@solidjs/web,babel-preset-solid→2.0.0-beta.29vite-plugin-solid→3.0.0-next.21(peer-requires>=2.0.0-beta.29, ships@dom-expressions/compiler@0.50.0-next.34)@tanstack/solid-query+@tanstack/solid-query-devtools→6.0.0-beta.7Notes on the solid-query bump
@tanstack/solid-queryis pinned through thecatalog:entry inpnpm-workspace.yamland forced repo-wide byoverrides: '@tanstack/solid-query': 'catalog:'. Bumping the package.json ranges alone has no effect on resolution — the catalog entry is the authoritative knob, so it is bumped too. (@tanstack/solid-query-devtoolsis not in the catalog, so it resolves straight from its package.json range.)@tanstack/solid-query-devtools@6.0.0-beta.7peer-requires@tanstack/solid-query: ^6.0.0-beta.7, so the two must move together.Both are added to
minimumReleaseAgeExclude, since the repo gates onminimumReleaseAge: 1440and these betas are newer than that.Verification
Each commit was verified independently; the results below are for the final state.
packages/solid-routertest:unit(client)packages/solid-routertest:unit(server)e2e/solid-start/basic-solid-querye2e/solid-start/basice2e/solid-router/basic-file-basedpnpm build:allAll counts match the beta.27 baseline — no regressions.