docs: use the dynamic README header endpoint - #7940
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughREADME header images now use responsive ChangesTheme-aware README headers
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d0f0fad
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Bundle Size BenchmarksThis pull request does not affect bundle size in any measured scenario. |
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment state issue rather than a code change. The PR only modifies README files, and the e2e test failed solely because port 33611 was already occupied by another process in the CI environment — entirely unrelated to the documentation updates. Re-running the pipeline once the port is freed should resolve this.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
Merging this PR will regress 3 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server peak-large-page (react) |
943.8 KB | 2,220.7 KB | -57.5% |
| ❌ | Memory | mem server serialization-payload (react) |
3.4 MB | 5.3 MB | -35.56% |
| ❌ | Simulation | ssr control-flow unmatched 404 (react) |
58.4 ms | 60.3 ms | -3.15% |
| ⚡ | Memory | mem server error-paths redirect (vue) |
767.3 KB | 295.9 KB | ×2.6 |
| ⚡ | Memory | mem server error-paths not-found (solid) |
790.6 KB | 422.6 KB | +87.09% |
| ⚡ | Memory | mem server peak-large-page (solid) |
826.3 KB | 773.4 KB | +6.84% |
| ⚡ | Simulation | client-loaders navigation loop (react) |
55.5 ms | 52.7 ms | +5.31% |
| ⚡ | Memory | mem server error-paths not-found (react) |
280.7 KB | 266.8 KB | +5.2% |
| ⚡ | Memory | mem server server-fn-churn (react) |
281.8 KB | 271.4 KB | +3.81% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing readme-header-endpoint (d0f0fad) with main (03699c4)1
Adopts the dynamic README header endpoint added in TanStack/tanstack.com#1076,
which is merged and live.
Every README banner in this repo now points a
<picture>athttps://tanstack.com/api/readme/instead of a committed PNG. The endpointrenders 1800x450 in light and dark, so a branding change lands in every README
at once and dark-mode readers get a dark banner.
What changed
<picture>, per GitHub's guidance. The trailing<img>stays the light variant, as the fallback for renderers that ignore<picture>(npm, most editors).?framework=so each banner shows its own package name instead of the generic library name.media/header_router.png,media/header_start.png.The root README shows the Router and Start banners side by side in a two-column table, so those two omit
widthand stay fluid.packages/vue-routeruses?title=TanStack Vue Routerbecause the endpoint does not listvueas a Router framework yet.Verification
Every generated URL in this diff was requested against the live endpoint and
returned
200 image/pngat 1800x450.git grepconfirms no README stillreferences the old
media/header_*.pngpath.Heads up: deleting the committed PNG means npm pages for already-published
versions that embed the
raw.githubusercontent.com/.../main/media/header_*.pnglink will show a broken image, since that link is branch-pinned. New releases
pick up the endpoint URL.
Summary by CodeRabbit