fix: coerce accessor key to string during column creation#4835
Closed
jpedroh wants to merge 1 commit into
Closed
Conversation
jpedroh
marked this pull request as draft
May 2, 2023 12:49
jpedroh
marked this pull request as ready for review
May 2, 2023 13:16
|
hey @jpedroh, was there any issues with your PR? If not can you reopen it? |
Contributor
Author
|
hi @schardev! to be fair, I don't fully recall if there was any issue with the PR. I just don't have the original source code anymore unfortunately, so feel free to open a new one with this implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During render, if the accessorKey was not a string, e.g. a number, it would result in an error when trying to normalize it during column creation, because it was trying to access methods which are not available in a number (replace and include). This PR forces the accessor key to be constructed as a string during column creation, thus removing this bug.
fixes #4815