Skip to content

TD-7456 Update The DLS Web Projects To .NET 10 - #3723

Open
rshrirohit wants to merge 1 commit into
DLS-Release-v1.3.2from
Develop/Fixes/TD-7456-UpdateTheDLSWebProjectsToNET10
Open

TD-7456 Update The DLS Web Projects To .NET 10#3723
rshrirohit wants to merge 1 commit into
DLS-Release-v1.3.2from
Develop/Fixes/TD-7456-UpdateTheDLSWebProjectsToNET10

Conversation

@rshrirohit

@rshrirohit rshrirohit commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

JIRA link

TD-7456

Description

Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@rshrirohit
rshrirohit marked this pull request as ready for review August 3, 2026 13:32

@Auldrin-Possa Auldrin-Possa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevwhitt-hee kevwhitt-hee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing to check before I approve - see comments

Comment thread DigitalLearningSolutions.Data/DigitalLearningSolutions.Data.csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants