Logging redesign#1547
Merged
Merged
Conversation
Domonion
force-pushed
the
kononov-logs
branch
2 times, most recently
from
December 16, 2022 14:15
3f72d71 to
7f97aa5
Compare
Domonion
marked this pull request as draft
December 16, 2022 14:32
Domonion
force-pushed
the
kononov-logs
branch
2 times, most recently
from
December 16, 2022 14:41
3c3a624 to
145e036
Compare
Domonion
force-pushed
the
kononov-logs
branch
from
January 13, 2023 08:16
145e036 to
3b88fee
Compare
Domonion
force-pushed
the
kononov-logs
branch
2 times, most recently
from
January 26, 2023 13:02
ae0546c to
4d86647
Compare
Domonion
marked this pull request as ready for review
January 26, 2023 13:03
sergeypospelov
requested changes
Jan 27, 2023
sergeypospelov
left a comment
sergeypospelov
left a comment
Member
There was a problem hiding this comment.
Looks OK after fixing remarks, but I didn't dive into details deeply. I guess, you need to update docs.
Domonion
force-pushed
the
kononov-logs
branch
from
January 27, 2023 15:30
4d86647 to
5eac028
Compare
Domonion
force-pushed
the
kononov-logs
branch
from
January 27, 2023 16:07
9eb68e0 to
c54dc3b
Compare
Domonion
enabled auto-merge (squash)
January 27, 2023 16:20
Domonion
disabled auto-merge
January 30, 2023 12:50
sergeypospelov
approved these changes
Jan 31, 2023
Member
|
@Domonion Please add logging of Summarization phase: started - ended. |
Domonion
force-pushed
the
kononov-logs
branch
from
February 7, 2023 12:22
b8ae7bb to
2892c2e
Compare
sergeypospelov
approved these changes
Feb 8, 2023
Domonion
force-pushed
the
kononov-logs
branch
from
February 8, 2023 13:50
b2b4df5 to
c96c830
Compare
EgorkaKulikov
self-requested a review
February 8, 2023 13:54
EgorkaKulikov
approved these changes
Feb 8, 2023
Domonion
enabled auto-merge (squash)
February 8, 2023 13:55
Complete logs redesign: 1. Added Logger model to rd. 2. InstrumentedProcess is now sending all logs to EngineProcess, which then writes to its own file. 3. Removed UtSettings.instrumentedProcessLogLevel 4. Auxiliary log functions 5. UtRdLoggers redesigned to have the same logging pattern 6. From now log4j2.xml is responsible for instrumentation process log configuration 7. Added summarization start/end log notifications and instrumented process starting messages. 8. Design doc for logs, clarifying comments and refactoring. 9. Changed `bracket` to `logMeasure`. its signature from plain string message to lambda to remove extra interpolation when message log level is not supported/
Domonion
force-pushed
the
kononov-logs
branch
from
February 8, 2023 14:16
c96c830 to
719262f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1122
Type of Change