Fix the way of setting static final fields#466
Merged
sergeypospelov merged 3 commits intoJul 11, 2022
Conversation
sergeypospelov
force-pushed
the
sergey/fix-the-way-of-setting-static-final-fields
branch
from
July 11, 2022 06:55
cfe7bc1 to
25c7789
Compare
CaelmBleidd
approved these changes
Jul 11, 2022
Damtev
requested changes
Jul 11, 2022
Damtev
left a comment
Member
There was a problem hiding this comment.
Do we really need this dependency on the utbot-sample? Please consider the idea of moving the test class to the "utbot-core" module.
Damtev
approved these changes
Jul 11, 2022
sergeypospelov
enabled auto-merge (squash)
July 11, 2022 10:31
sergeypospelov
force-pushed
the
sergey/fix-the-way-of-setting-static-final-fields
branch
2 times, most recently
from
July 11, 2022 11:06
6a6c293 to
5c9a78c
Compare
sergeypospelov
force-pushed
the
sergey/fix-the-way-of-setting-static-final-fields
branch
from
July 11, 2022 12:01
5c9a78c to
1d7d138
Compare
sergeypospelov
deleted the
sergey/fix-the-way-of-setting-static-final-fields
branch
July 11, 2022 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merged
withAccessibilityandwithRemovedFinalModiferfunction inReflectionUtil.kt, so it won't be possible to get the wrong cached FieldAccessor field, if we use our function.Fixes #458
Type of Change
How Has This Been Tested?
Manual Scenario
Repeated To Reproduce section from #458. Tests are successfully generated.
Checklist (remove irrelevant options):