CHANGE: Bump version to 1.20.1#2455
Conversation
![u-pr[bot]](https://cdn.github.com/in/1201017?s=60&v=4){kind=small}
| "ValidationTest": "API Validation", | ||
| "ExceptionMessage": "Additions require a new minor or major version.", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" |
There was a problem hiding this comment.
Updating this generic API-validation exemption to 1.20.1 keeps it active for every future 1.20.1 build, because the entry is keyed only by PackageVersion plus the broad message "Additions require a new minor or major version." The similar "Breaking changes require a new major version." entry above has the same problem. That means any new API additions or breaks merged on develop before the next version bump will be silently exempted instead of failing validation, which defeats the semver guardrail for the whole 1.20.1 window. Please either drop these blanket exceptions when moving off the 1.20.0 release, or narrow them to the specific known false positives only.
🤖 Helpful? 👍/👎
| "ValidationTest": "API Validation", | ||
| "ExceptionMessage": "Additions require a new minor or major version.", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" |
There was a problem hiding this comment.
Do we need to upgrade this here to 1.20.1 ? It's the only concern I have, since we might lose visibility in changes we do while in 1.20.1, since we are ignoring it. If you don't bump this, what happens?
There was a problem hiding this comment.
I tried and it was still failing like the exception comments suggest. I believe all of them are still needed
| "PackageVersion": "1.20.1", | ||
| "__comments": "starting from 2022.3 ugui is not added to the project by default. We have some APIs that are conditional on ugui being present, so the API Validation thinks we are breaking API, but that is not the case." | ||
| }, | ||
| { | ||
| "ValidationTest": "API Validation", | ||
| "ExceptionMessage": "New assembly \"Unity.InputSystem.TestFramework\" may only be added in a new minor or major version.", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" | ||
| }, | ||
| { | ||
| "ValidationTest": "API Validation", | ||
| "ExceptionMessage": "Additions require a new minor or major version.", | ||
| "PackageVersion": "1.20.0" | ||
| "PackageVersion": "1.20.1" |
There was a problem hiding this comment.
I meant all of these bumps with my previous comment
This reverts commit 03b53c3.
2 participants
Description
Bumps develop version to a temporary 1.20.1 one
Testing status & QA
CI Only
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Note that I also updated the validation exceptions as per the most recent note in our release doc
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.