Skip to content

Keep the pasted credential across the wizard's mid-flow refetch - #1499

Merged
RhysSullivan merged 1 commit into
mainfrom
fix/add-account-wizard-credential-wipe
Jul 29, 2026
Merged

Keep the pasted credential across the wizard's mid-flow refetch#1499
RhysSullivan merged 1 commit into
mainfrom
fix/add-account-wizard-credential-wipe

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Main's E2E has been red since #1483 (connect-handoff, connect-handoff-session, connect-link-multi-org). Two causes, both in the add-connection wizard:

  • The handoff-prefill effect depends on allMethods, whose identity changes whenever the integration refetches. Fix GraphQL introspection health diagnostics #1483 made Continue probe the key and save the health check, which triggers exactly such a refetch mid-flow — re-running the reset and calling setValues({}), wiping the credential the user just pasted. Step 2's Add connection button then stays disabled forever. The prefill now applies once per handoff key.
  • Continue treated every non-healthy probe as blocking. A never-served base URL (connect-link-multi-org saves a credential unprobed by design) reads as degraded/unknown, which stranded the user on step 1. Only a definitive credential rejection (expired, the 401/403 wall) blocks now; inconclusive probes advance.

Verified: connect-handoff + connect-handoff-session (selfhost), connect-handoff-session + connect-link-multi-org (cloud), and graphql-introspection-health (selfhost, the scenario #1483 added — its 401 path still blocks) all pass locally. Unit tests, lint, typecheck, format green.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 26c8805 Commit Preview URL

Branch Preview URL
Jul 29 2026, 08:42 PM

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 26c8805 Jul 29 2026, 08:42 PM

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1499

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1499

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1499

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1499

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1499

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1499

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1499

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1499

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1499

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1499

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1499

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1499

executor

npm i https://pkg.pr.new/executor@1499

commit: 26c8805

@RhysSullivan
RhysSullivan marked this pull request as ready for review July 29, 2026 21:03
@RhysSullivan
RhysSullivan merged commit 010ea98 into main Jul 29, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant