fix: handle undefined MessageEvent in postMessageStream#402
Merged
Conversation
9 tasks
chaitanyapotti
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
Description
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Note
Low Risk
Small defensive guard at module init with unchanged browser behavior when MessageEvent is present; limited to JRPC postMessage stream setup.
Overview
Fixes a module-load crash when
MessageEventis missing (e.g. Hermes/React Native).postMessageStreamno longer readsMessageEvent.prototypeat import time; it only resolves thesource/originproperty getters whenMessageEventexists, and the existing_onMessageHandlerfallbacks toevent.origin/event.sourcestill apply when those getters are absent.Adds a test that deletes global
MessageEventand assertsimport("../src/jrpc")still exposesPostMessageStream.Reviewed by Cursor Bugbot for commit 2cf89be. Bugbot is set up for automated code reviews on this repo. Configure here.