Fixes if:cancelled() composite steps not running and normal composite steps not interrupting when the job is cancelled.

[fhammerl]

This fix gives composite steps their own cancellation tokens instead of sharing one from their parent step (usually the workflow step that uses: the composite action).
This separation of tokens exposed a bug where action_status was not set to cancelled when the job is cancelled, which would allow an if: success() composite step to not be interrupted in the event of cancellation. Fixed it by setting action_status to cancelled in CompositeActionHandler when the job is cancelled.

Bug description: an if:cancelled() composite action step is not always executed when the job is cancelled while the composite action is running.

Such a step should run given:

• The composite action is entered (the parent step that uses:' it starts executing)
• The step itself is cancelled()
• The job is cancelled

Workflow steps have their own cancellation tokens. When a job is cancelled, the currently running step's cancellation token is triggered, unless the step is always or cancelled. The token of a 'success' step is cancelled. This token is used to interrupt any process invoked by that step, e.g. 'sleep 600'.

Other steps, with their 'untriggered' cancellation tokens in the workflow are then evaluated for their if: conditions and run accordingly.

Composite action steps all share their parent steps cancellation token (in order to inherit a stepTimeout set on their parent step - this was introduced when composite actions could not have conditional steps). Just like in workflow steps: When a job is cancelled, the currently running step's cancellation token is triggered, unless the step is always or cancelled. The token of a 'success' step is cancelled. This token is used to interrupt any process invoked by that step, e.g. 'sleep 600'.

Other steps, with their 'untriggered' cancellation tokens in the workflow are then evaluated for their if: conditions and try to run accordingly, but because they share a cancellation token, this token interrupts any process started by them, leading to none of these processes finishing, even if they are cancelled or always.
This bug does not show if the interrupted composite step is always or cancelled, because then the shared token is not cancelled.

Bug repro

...   
    steps:
      - uses: fhammerl/nested-composite/actions/composite-steps@main

fhammerl/nested-composite/actions/composite-steps@main

name: My Composite Action
description: A composite action with four steps

runs:
  using: "composite"
  steps:
    - name: Sleep 
      run: sleep 121 # Cancelling the job will interrupt this composite step
      shell: bash

    - run: echo foo
      if: cancelled() # Doesn't run due to the bug
      shell: bash

[fhammerl]

This token used to be linked so that stepTimeout would propagate down
We don't need to share a token if we set a new stepTimeout instead, calculated as parent step's timeout - timeElapsed

[fhammerl]

m_timeoutSetAt - perhaps m_timeoutStartedAt?

[rentziass]

Just m_startedAt? so that elapsed = DateTime.UtcNow - m_startedAt.Value

[fhammerl]

I'd rather keep it m_timeoutStartedAt to clearly imply it's for timeout related stuff, unlike _record.StartedAt

[fhammerl]

Inherit the parent's remaining timeout

[nikola-jokic]

LGTM

[rentziass]

🚀