fix: PathEscape project name in DMS to SQLE URLs - #653
Merged
Conversation
Encode project name path segments so Chinese project names work when DMS calls SQLE APIs that use project_name in the URL. Fixes actiontech/dms-ee#936
PR Reviewer Guide 🔍(Review updated until commit 69f9067)
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Encode project_name when calling auto_create_and_execute so Chinese project names work for ODC/SQL Workbench non-DQL workflow execution. Fixes actiontech/dms-ee#936
|
Persistent review updated to latest commit 69f9067 |
Seechi-Yolo
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
project_namewhen DMS builds SQLE URLs that place the name in the path (db_service, CloudBeaver auto workflow, SQL Workbench auto workflow).Test plan
Fixes actiontech/dms-ee#936
Description
使用 url.PathEscape 对项目名称进行编码
更新 Cloudbeaver、DBService 与 Workbench 相关 URL 构建方式
确保中文项目名称在 SQLE 调用中正确传递
Diagram Walkthrough
File Walkthrough
cloudbeaver.go
Cloudbeaver 项目名称 URL 编码更新internal/dms/biz/cloudbeaver.go
db_service.go
DBService 项目名称 URL 编码更新internal/dms/biz/db_service.go
workflow_exec.go
SQL Workbench 项目名称 URL 编码更新internal/sql_workbench/service/workflow_exec.go