Skip to content

fix: remove MongoDB legacy advanced param ignore paths - #655

Merged
Seechi-Yolo merged 4 commits into
mainfrom
dev-decathlon-mongo-odc-visibility
Jul 28, 2026
Merged

fix: remove MongoDB legacy advanced param ignore paths#655
Seechi-Yolo merged 4 commits into
mainfrom
dev-decathlon-mongo-odc-visibility

Conversation

@LordofAvernus

@LordofAvernus LordofAvernus commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

关联的 issue

https://github.com/actiontech/dms-ee/issues/941

描述你的变更

  • 移除 MongoDB 数据源高级选项(auth_mechanism / tls / tls_skip_verify / direct_connection),前后端与插件 meta/DSN 一并删除
  • 形态文案统一为「单机 / 副本集 / 分片集群」
  • 不再保留遗留四键的读取忽略 / 兼容 shim(开发期不引入向后兼容)
  • 补充/调整相关单测

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

Skip deprecated additional_params on create/update/test-connect and stop forwarding TLS/authMechanism/directConnection to ODC.
Align unit tests with jdbcParams that only keep authSource/replicaSet.
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 5ae363c)

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
统一参数名称大小写

建议在进行老参数过滤时,将参数名称转换为统一的小写形式进行匹配。否则可能因大小写不一致导致未能正确过滤需要忽略的参数,从而引起潜在的逻辑错误。

internal/dms/service/mongo_legacy_params.go [13-19]

 func isDeprecatedMongoAdditionalParam(dbType, name string) bool {
 	if !strings.EqualFold(dbType, "MongoDB") {
 		return false
 	}
-	_, ok := deprecatedMongoAdditionalParams[name]
+	_, ok := deprecatedMongoAdditionalParams[strings.ToLower(name)]
 	return ok
 }
Suggestion importance[1-10]: 5

__

Why: The suggestion proposes a minor improvement by converting the parameter name to lower-case to ensure consistent matching. While valid, the change is a small enhancement with limited impact on overall functionality.

Low

@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 5ae363c

@LordofAvernus LordofAvernus changed the title fix: ignore MongoDB legacy advanced params in DMS paths fix: remove MongoDB legacy advanced param ignore paths Jul 28, 2026
@Seechi-Yolo
Seechi-Yolo merged commit 7eeed8e into main Jul 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants